From: Christoph Hellwig <hch@infradead.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: Denys Vlasenko <vda.linux@googlemail.com>,
David Chinner <dgc@sgi.com>,
xfs@oss.sgi.com, Eric Sandeen <sandeen@sandeen.net>,
Adrian Bunk <bunk@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc()
Date: Sat, 26 Apr 2008 16:07:01 -0400 [thread overview]
Message-ID: <20080426200701.GA10883@infradead.org> (raw)
In-Reply-To: <87iqy4wfjq.fsf@basil.nowhere.org>
On Sat, Apr 26, 2008 at 10:02:17PM +0200, Andi Kleen wrote:
> Denys Vlasenko <vda.linux@googlemail.com> writes:
> >
> > Compile tested only.
>
> You should mark the helper noinline just to prevent gcc from possibly
> inlining it. Even if it doesn't with your current compiler inline heuristics
> vary widely between compiler versions.
STATIC as defined by xfs already does this..
next prev parent reply other threads:[~2008-04-26 20:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200804261651.02078.vda.linux__2040.04651536724$1209223026$gmane$org@googlemail.com>
2008-04-26 20:02 ` [PATCH] xfs: reduce stack usage in xfs_bmap_btalloc() Andi Kleen
2008-04-26 20:07 ` Christoph Hellwig [this message]
2008-04-26 20:26 ` Andi Kleen
2008-04-26 20:23 ` Christoph Hellwig
2008-04-28 0:06 ` Nathan Scott
2008-04-28 5:56 ` Christoph Hellwig
2008-04-28 10:32 ` Andi Kleen
2008-04-28 23:52 ` Nathan Scott
2008-04-26 14:51 Denys Vlasenko
2008-04-26 18:54 ` Eric Sandeen
2008-04-26 23:05 ` Denys Vlasenko
2008-04-26 20:03 ` Christoph Hellwig
2008-04-26 23:45 ` Denys Vlasenko
2008-04-27 23:40 ` David Chinner
2008-04-27 23:57 ` Denys Vlasenko
2008-04-28 3:32 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080426200701.GA10883@infradead.org \
--to=hch@infradead.org \
--cc=andi@firstfloor.org \
--cc=bunk@kernel.org \
--cc=dgc@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeen@sandeen.net \
--cc=vda.linux@googlemail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.