From: Jens Axboe <jens.axboe@oracle.com>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
Cell Broadband Engine OSS Development <cbe-oss-dev@ozlabs.org>
Subject: Re: [PATCH] ps3disk: Remove superfluous cast
Date: Sun, 27 Apr 2008 12:35:34 +0200 [thread overview]
Message-ID: <20080427103534.GU12774@kernel.dk> (raw)
In-Reply-To: <Pine.LNX.4.64.0804231357170.13313@vixen.sonytel.be>
On Wed, Apr 23 2008, Geert Uytterhoeven wrote:
> As ps3disk is a ppc64-only driver, sector_t equals to unsigned long, and the
> cast is not needed.
>
> Reuse in another (possibly 32-bit) driver is protected by the safety net called
> `compiler warning' (with the cast, it may silently truncate to 32-bit).
> If sector_t ever changes, we will get a compiler warning as well (with the
> cast, we won't).
>
> Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
> Acked-by: Christoph Hellwig <hch@lst.de>
> ---
> Please apply, thx!
Applied
--
Jens Axboe
next prev parent reply other threads:[~2008-04-27 10:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-23 12:00 [PATCH] ps3disk: Remove superfluous cast Geert Uytterhoeven
2008-04-27 10:35 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-10-12 14:14 Geert Uytterhoeven
2007-10-12 14:14 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080427103534.GU12774@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=akpm@linux-foundation.org \
--cc=cbe-oss-dev@ozlabs.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.