All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] siimage: coding style cleanup (take 2)
Date: Sun, 27 Apr 2008 20:37:06 +0200	[thread overview]
Message-ID: <200804272037.06406.bzolnier@gmail.com> (raw)
In-Reply-To: <200804222056.38802.sshtylyov@ru.mvista.com>

On Tuesday 22 April 2008, Sergei Shtylyov wrote:
> Fix 18 errors and several warnings given by checkpatch.pl:
> 
> - use of C99 // comments;
> 
> - trailing whitespace;
> 
> - 'switch' and 'case' not at the same indentation level;
> 
> - no space before the open parenthesis of the 'if' and 'switch' statements;
> 
> - space between function name and open parenthesis (though I have introduced
>   such warnins in some places since the code looks prettier with the spaces);
> 
> - including <asm/io.h> instead of <linux/io.h>;
> 
> - line over 80 characters.
> 
> In addition to these changes, also do the following:
> 
> - make the arrays in sil_set_pio_mode() 'static', and make the arrays in
>   sil_set_dma_mode() 'static const';
> 
> - change the string of the 'if' statements into the 'switch' statement in
>   sil_pata_udma_filter();
> 
> - drop the needless '==' operators from the 'if' statements where a condition
>   is a mere bit test;
> 
> - remove needless initializer for the 'tmp' variable in init_chipset_siimage();
> 
> - beautify groups of the variable initializers and assignment operators;
> 
> - add new line after variable definitions;
> 
> - remove new line between the comment and the statements it refers to;
> 
> - remove needless curly braces and parentheses;
> 
> - fix typos, capitalize acronyms, etc. in the comments...
> 
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

applied

      parent reply	other threads:[~2008-04-27 19:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-22 16:56 [PATCH] siimage: coding style cleanup (take 2) Sergei Shtylyov
2008-04-22 17:11 ` James Courtier-Dutton
2008-04-27 19:34   ` Bartlomiej Zolnierkiewicz
2008-04-27 18:37 ` Bartlomiej Zolnierkiewicz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200804272037.06406.bzolnier@gmail.com \
    --to=bzolnier@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=sshtylyov@ru.mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.