All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <Uwe.Kleine-Koenig@digi.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Justin Waters <justin.waters@timesys.com>,
	dmitry.torokhov@gmail.com,
	linux-arm-kernel@lists.arm.linux.org.uk, linux@maxim.org.za,
	linux-input@vger.kernel.org
Subject: Re: [PATCH 1/2] atmel_tsadcc: Device driver for AT91SAM9RL Touchscreen
Date: Mon, 28 Apr 2008 07:55:58 +0200	[thread overview]
Message-ID: <20080428055558.GC9804@digi.com> (raw)
In-Reply-To: <20080425211041.GC28497@flint.arm.linux.org.uk>

Hello,

> > +	/* Setup Clock */
> > +	ts->tsc_clk = clk_get(&pdev->dev,"tsc_clk");
> > +	if (IS_ERR(ts->tsc_clk)) {
> 
> Great, nice to see a driver using the clock API properly.
> 
> > +		dev_err(&pdev->dev, "unable to get clock\n");
> > +		err = PTR_ERR(ts->tsc_clk);
> > +		goto err_iounmap;
> > +        }
> 
> Odd indentation on the last line above.
> 
> > +	clk_enable(ts->tsc_clk);
To use the clock API properly you should check the return value of
clk_enable, too :-)

Uwe

-- 
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2008-04-28  5:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-25 18:56 [PATCH 0/2] Atmel AT91SAM9RL Touchscreen Driver Justin Waters
2008-04-25 18:56 ` [PATCH 1/2] atmel_tsadcc: Device driver for AT91SAM9RL Touchscreen Justin Waters
2008-04-25 18:56   ` [PATCH 2/2] atmel_tsadcc: Add board specific information for touchscreen driver Justin Waters
2008-04-25 22:29     ` Andrew Victor
2008-04-25 20:34   ` [PATCH 1/2] atmel_tsadcc: Device driver for AT91SAM9RL Touchscreen Dmitry Torokhov
2008-04-25 21:10   ` Russell King - ARM Linux
2008-04-25 21:37     ` Justin Waters
2008-04-25 22:52       ` David Brownell
2008-06-05 13:49       ` Haavard Skinnemoen
2008-04-25 22:16     ` Andrew Victor
2008-04-28  5:55     ` Uwe Kleine-König [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080428055558.GC9804@digi.com \
    --to=uwe.kleine-koenig@digi.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=justin.waters@timesys.com \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-input@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=linux@maxim.org.za \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.