From: Al Viro <viro@ZenIV.linux.org.uk>
To: "Zhang, Xiantao" <xiantao.zhang@intel.com>
Cc: Al Viro <viro@ftp.linux.org.uk>,
torvalds@linux-foundation.org, sfr@canb.auug.org.au,
linux-kernel@vger.kernel.org,
kvm-ia64-devel@lists.sourceforge.net
Subject: Re: [kvm-ia64-devel] [PATCH] ia64 kvm fixes for O=... builds
Date: Mon, 28 Apr 2008 15:14:02 +0100 [thread overview]
Message-ID: <20080428141402.GD5882@ZenIV.linux.org.uk> (raw)
In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC011CA51F@pdsmsx415.ccr.corp.intel.com>
On Mon, Apr 28, 2008 at 09:46:44PM +0800, Zhang, Xiantao wrote:
> > kvm-intel-objs = vmm.o vmm_ivt.o trampoline.o vcpu.o optvfault.o
> > mmio.o \ vtlb.o process.o
> > #Add link memcpy and memset to avoid possible structure assignment
> > error -kvm-intel-objs += memset.o memcpy.o
> > +kvm-intel-objs += ../lib/memset.o ../lib/memcpy.o
> > obj-$(CONFIG_KVM_INTEL) += kvm-intel.o
>
> I don't think it is workable for kvm-ia64. Currently, kvm-intel module
> needs to be relocated at insertion time, so the code is
> position-indenpent. Howerver, lib/*.memset.o(memcoy.o) are not compiled
> as position independent code, they can't be linked into the module
> correctly in your way. That is why we use symbol link instead of linking
> the objects under /lib.
symlinks won't work as you use them. If you really need separately
compiled, use file with a couple of #include "../lib/......S" and
be done with that.
next prev parent reply other threads:[~2008-04-28 14:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 5:59 [PATCH] ia64 kvm fixes for O=... builds Al Viro
2008-04-28 13:46 ` [kvm-ia64-devel] " Zhang, Xiantao
2008-04-28 14:14 ` Al Viro [this message]
2008-04-28 18:24 ` Al Viro
2008-05-04 1:01 ` Zhang, Xiantao
2008-05-04 12:31 ` Avi Kivity
2008-05-05 1:21 ` Zhang, Xiantao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080428141402.GD5882@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=kvm-ia64-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
--cc=xiantao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.