From: Yinghai Lu <yhlu.kernel.send@gmail.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>,
Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Subject: [PATCH] x86/pci: remove flag in pci_cfg_space_size_ext
Date: Mon, 28 Apr 2008 16:27:23 -0700 [thread overview]
Message-ID: <200804281627.23566.yhlu.kernel@gmail.com> (raw)
In-Reply-To: <200804281334.16713.jbarnes@virtuousgeek.org>
so let pci_cfg_space_size call it directly without flag.
Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
diff --git a/arch/x86/pci/fixup.c b/arch/x86/pci/fixup.c
index b60b2ab..ff3a6a3 100644
--- a/arch/x86/pci/fixup.c
+++ b/arch/x86/pci/fixup.c
@@ -502,7 +502,7 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_SIEMENS, 0x0015,
*/
static void fam10h_pci_cfg_space_size(struct pci_dev *dev)
{
- dev->cfg_size = pci_cfg_space_size_ext(dev, 0);
+ dev->cfg_size = pci_cfg_space_size_ext(dev);
}
DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_AMD, 0x1200, fam10h_pci_cfg_space_size);
diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index 4a55bf3..3706ce7 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -842,13 +842,25 @@ static void set_pcie_port_type(struct pci_dev *pdev)
* reading the dword at 0x100 which must either be 0 or a valid extended
* capability header.
*/
-int pci_cfg_space_size_ext(struct pci_dev *dev, unsigned check_exp_pcix)
+int pci_cfg_space_size_ext(struct pci_dev *dev)
{
- int pos;
u32 status;
- if (!check_exp_pcix)
- goto skip;
+ if (pci_read_config_dword(dev, 256, &status) != PCIBIOS_SUCCESSFUL)
+ goto fail;
+ if (status == 0xffffffff)
+ goto fail;
+
+ return PCI_CFG_SPACE_EXP_SIZE;
+
+ fail:
+ return PCI_CFG_SPACE_SIZE;
+}
+
+int pci_cfg_space_size(struct pci_dev *dev)
+{
+ int pos;
+ u32 status;
pos = pci_find_capability(dev, PCI_CAP_ID_EXP);
if (!pos) {
@@ -861,23 +873,12 @@ int pci_cfg_space_size_ext(struct pci_dev *dev, unsigned check_exp_pcix)
goto fail;
}
- skip:
- if (pci_read_config_dword(dev, 256, &status) != PCIBIOS_SUCCESSFUL)
- goto fail;
- if (status == 0xffffffff)
- goto fail;
-
- return PCI_CFG_SPACE_EXP_SIZE;
+ return pci_cfg_space_size_ext(dev);
fail:
return PCI_CFG_SPACE_SIZE;
}
-int pci_cfg_space_size(struct pci_dev *dev)
-{
- return pci_cfg_space_size_ext(dev, 1);
-}
-
static void pci_release_bus_bridge_dev(struct device *dev)
{
kfree(dev);
diff --git a/include/linux/pci.h b/include/linux/pci.h
index 8f53f4b..e9b4fcb 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -667,7 +667,7 @@ int pci_scan_bridge(struct pci_bus *bus, struct pci_dev *dev, int max,
void pci_walk_bus(struct pci_bus *top, void (*cb)(struct pci_dev *, void *),
void *userdata);
-int pci_cfg_space_size_ext(struct pci_dev *dev, unsigned check_exp_pcix);
+int pci_cfg_space_size_ext(struct pci_dev *dev);
int pci_cfg_space_size(struct pci_dev *dev);
unsigned char pci_bus_max_busnr(struct pci_bus *bus);
next prev parent reply other threads:[~2008-04-28 23:27 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-26 18:55 [RFC git pull] "big box" x86 changes Ingo Molnar
2008-04-26 19:05 ` Stefan Richter
2008-04-26 19:21 ` Ingo Molnar
2008-04-26 19:12 ` Linus Torvalds
2008-04-26 19:41 ` [git pull] "big box" x86 changes, bootmem/sparsemem Ingo Molnar
2008-04-26 19:52 ` Linus Torvalds
2008-04-26 20:07 ` Ingo Molnar
2008-04-26 20:08 ` [git pull] "big box" x86 changes, bootmem/sparsemem, #2 Ingo Molnar
2008-04-26 20:30 ` Linus Torvalds
2008-04-26 20:55 ` [git pull] "big box" x86 changes, bootmem/sparsemem, #3 Ingo Molnar
2008-04-27 22:48 ` [git pull] "big box" x86 changes, bootmem/sparsemem Johannes Weiner
2008-04-27 23:46 ` Ingo Molnar
2008-04-28 0:19 ` Johannes Weiner
2008-04-28 0:40 ` [patch] mm: node-setup agnostic free_bootmem() Ingo Molnar
2008-04-28 1:48 ` Yinghai Lu
2008-04-28 16:54 ` Johannes Weiner
2008-04-28 19:11 ` Yinghai Lu
2008-04-28 19:55 ` Yinghai Lu
2008-04-30 10:50 ` Johannes Weiner
2008-04-30 16:22 ` Yinghai Lu
2008-04-30 17:52 ` Johannes Weiner
2008-04-30 20:30 ` Yinghai Lu
2008-04-28 16:49 ` Johannes Weiner
2008-04-29 14:25 ` Ingo Molnar
2008-04-30 10:52 ` Johannes Weiner
2008-04-28 0:33 ` [git pull] "big box" x86 changes, bootmem/sparsemem Yinghai Lu
2008-04-28 16:58 ` Johannes Weiner
2008-04-26 19:54 ` [git pull] "big box" x86 changes, boot protocol Ingo Molnar
2008-04-26 20:39 ` Andrew Morton
2008-04-26 21:06 ` Adrian Bunk
2008-04-26 21:10 ` H. Peter Anvin
2008-04-26 21:11 ` Linus Torvalds
2008-04-26 21:17 ` Ingo Molnar
2008-04-26 23:37 ` Jeremy Fitzhardinge
2008-04-27 11:21 ` Ian Campbell
2008-04-27 19:29 ` H. Peter Anvin
2008-04-28 15:27 ` Ingo Molnar
2008-04-26 20:24 ` [RFC git pull] "big box" x86 changes, GART Ingo Molnar
2008-04-26 20:26 ` Ingo Molnar
2008-04-26 21:55 ` [git pull] "big box" x86 changes, PCI Ingo Molnar
2008-04-27 16:30 ` Jesse Barnes
2008-04-28 15:38 ` Ingo Molnar
2008-04-28 20:34 ` Jesse Barnes
2008-04-28 22:53 ` Yinghai Lu
2008-04-28 23:27 ` Yinghai Lu [this message]
2008-04-29 16:14 ` [PATCH] x86/pci: remove flag in pci_cfg_space_size_ext Jesse Barnes
2008-04-29 22:05 ` Ingo Molnar
2008-04-29 22:34 ` Jesse Barnes
2008-04-26 22:17 ` [RFC git pull] "big box" x86 changes Andi Kleen
2008-04-27 3:14 ` Yinghai Lu
2008-04-27 8:30 ` Andi Kleen
2008-04-27 8:32 ` [RFC git pull] "big box" x86 changes II Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804281627.23566.yhlu.kernel@gmail.com \
--to=yhlu.kernel.send@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.