From: "SZEDER Gábor" <szeder@ira.uka.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] clone: detect and fail on excess parameters
Date: Mon, 28 Apr 2008 18:36:42 +0200 [thread overview]
Message-ID: <20080428163642.GA22790@neumann> (raw)
In-Reply-To: <7vfxtcsbis.fsf@gitster.siamese.dyndns.org>
Hi,
On Wed, Apr 23, 2008 at 10:53:47AM -0700, Junio C Hamano wrote:
> "git clone [options] $src $dst excess-garbage" simply ignored
> excess-garbage without giving any diagnostic message. Fix it.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> [...]
> --- a/git-clone.sh
> +++ b/git-clone.sh
> @@ -219,6 +219,7 @@ fi
> if test -n "$2"
> then
> dir="$2"
> + test $# == 2 || die "excess parameter to git-clone"
^^
I think you mean:
test $# = 2 || die "excess parameter to git-clone"
I just noticed because it broke t1020-subdirectory at me.
Best,
Gábor
next prev parent reply other threads:[~2008-04-28 16:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-23 17:53 [PATCH] clone: detect and fail on excess parameters Junio C Hamano
2008-04-28 16:36 ` SZEDER Gábor [this message]
2008-04-28 21:09 ` [PATCH] Use "=" instead of "==" in condition as it is more portable Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080428163642.GA22790@neumann \
--to=szeder@ira.uka.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.