All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Dike <jdike@addtoit.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Alexander van Heukelum <heukelum@mailshack.com>
Subject: Re: [git pull] generic bitops, take 2
Date: Mon, 28 Apr 2008 13:26:36 -0400	[thread overview]
Message-ID: <20080428172636.GF7334@c2.user-mode-linux.org> (raw)
In-Reply-To: <20080426172222.GD17345@elte.hu>

On Sat, Apr 26, 2008 at 07:22:22PM +0200, Ingo Molnar wrote:
> > It also makes me wonder why Kconfig.i386 can just include 
> > arch/x86/Kconfig.cpu, but x86_64 cannot?
> 
> hm, indeed arch/um/Kconfig.i386 is assymetric to Kconfig.x86_64. Jeff 
> Cc:-ed.

In current git, they look pretty symmetric to me, and it boots and runs.

>  arch/um/os-Linux/helper.c: In function 'run_helper':
>  arch/um/os-Linux/helper.c:73: error: 'PATH_MAX' undeclared (first use in this function)
> 
> it needs the patch below.

Applied, thanks.

> then it fails with:
> 
>  mm/filemap.c: In function '__generic_file_aio_write_nolock':
>  mm/filemap.c:1831: sorry, unimplemented: inlining failed in call to
> 'generic_write_checks': function body not available

Looks like Adrian just hit that too.  As Linus pointed out,
__generic_file_aio_write_nolock calls generic_write_checks at line
2383, and that's available at line 1831, which the error message
helpfully points out.  I don't see how gcc can be claiming that the
function body isn't available when it's telling you exactly where it
is.

				Jeff

-- 
Work email - jdike at linux dot intel dot com

  parent reply	other threads:[~2008-04-28 17:28 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-24 21:57 [git pull] generic bitops Ingo Molnar
2008-04-24 22:14 ` Linus Torvalds
2008-04-24 22:41   ` Harvey Harrison
2008-04-25 11:12   ` [PATCH] x86, bitops: select the generic bitmap search functions Alexander van Heukelum
2008-04-26 15:15   ` [git pull] generic bitops, take 2 Ingo Molnar
2008-04-26 17:03     ` Linus Torvalds
2008-04-26 17:22       ` Ingo Molnar
2008-04-26 17:28         ` Ingo Molnar
2008-04-26 17:50           ` [git pull] generic bitops, take 3 Ingo Molnar
2008-04-26 17:32         ` [git pull] generic bitops, take 2 Sam Ravnborg
2008-04-26 17:51         ` Miklos Vajna
2008-04-28 15:38         ` [2.6 patch] mm/filemap.c:generic_write_checks() mustn't be inline Adrian Bunk
2008-04-28 15:38         ` [2.6 patch] fs/buffer.c:init_buffer() " Adrian Bunk
2008-04-28 16:01           ` Linus Torvalds
2008-04-28 16:48             ` Adrian Bunk
2008-04-28 16:58               ` Linus Torvalds
2008-04-28 15:38         ` [2.6 patch] fs/block_dev.c:I_BDEV() " Adrian Bunk
2008-04-29  0:41           ` Linus Torvalds
2008-04-29  1:12             ` Al Viro
2008-04-29  1:21               ` Linus Torvalds
2008-04-29  2:32             ` Jeff Dike
2008-04-29  4:57               ` Sam Ravnborg
2008-04-29  8:06             ` Adrian Bunk
2008-04-29  8:17               ` Sam Ravnborg
2008-04-29  9:03                 ` Adrian Bunk
2008-04-28 15:38         ` [2.6 patch] block/blk-barrier.c:blk_ordered_cur_seq() " Adrian Bunk
2008-04-29  7:46           ` Jens Axboe
2008-04-28 15:38         ` [2.6 patch] net/ipv4/ip_output.c:ip_send_check() " Adrian Bunk
2008-04-28 15:38         ` [2.6 patch] reiserfs: some functions " Adrian Bunk
2008-04-28 15:38           ` Adrian Bunk
2008-04-29 22:43           ` Edward Shishkin
2008-04-29 22:43             ` Edward Shishkin
2008-04-28 15:38         ` [2.6 patch] fs/udf/partition.c:udf_get_pblock() " Adrian Bunk
2008-04-28 16:47           ` Jan Kara
2008-04-28 17:26         ` Jeff Dike [this message]
2008-04-26 17:34       ` [git pull] generic bitops, take 2 Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080428172636.GF7334@c2.user-mode-linux.org \
    --to=jdike@addtoit.com \
    --cc=akpm@linux-foundation.org \
    --cc=heukelum@mailshack.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.