All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: davem@davemloft.net
Cc: Patrick McHardy <kaber@trash.net>, netfilter-devel@vger.kernel.org
Subject: [NETFILTER 01/03]: xt_TCPOPTSTRIP: signed tcphoff for	ipv6_skip_exthdr() retval
Date: Tue, 29 Apr 2008 00:06:41 +0200 (MEST)	[thread overview]
Message-ID: <20080428220645.18270.96401.sendpatchset@localhost.localdomain> (raw)
In-Reply-To: <20080428220643.18270.24909.sendpatchset@localhost.localdomain>

[NETFILTER]: xt_TCPOPTSTRIP: signed tcphoff for	ipv6_skip_exthdr() retval

if tcphoff remains unsigned, a negative ipv6_skip_exthdr() return value will
go unnoticed,

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Signed-off-by: Patrick McHardy <kaber@trash.net>

---
commit 409c904821b52f9c4597ca87f3ab01b55183904e
tree 648fe90316d4c3d8e714ceefc9137325e8ef8417
parent 358c12953b88c5a06a57c33eb27c753b2e7934d1
author Roel Kluin <12o3l@tiscali.nl> Mon, 28 Apr 2008 20:58:54 +0200
committer Patrick McHardy <kaber@trash.net> Mon, 28 Apr 2008 20:58:54 +0200

 net/netfilter/xt_TCPOPTSTRIP.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/netfilter/xt_TCPOPTSTRIP.c b/net/netfilter/xt_TCPOPTSTRIP.c
index 3b2aa56..9685b6f 100644
--- a/net/netfilter/xt_TCPOPTSTRIP.c
+++ b/net/netfilter/xt_TCPOPTSTRIP.c
@@ -90,7 +90,7 @@ tcpoptstrip_tg6(struct sk_buff *skb, const struct net_device *in,
 		const struct xt_target *target, const void *targinfo)
 {
 	struct ipv6hdr *ipv6h = ipv6_hdr(skb);
-	unsigned int tcphoff;
+	int tcphoff;
 	u_int8_t nexthdr;
 
 	nexthdr = ipv6h->nexthdr;

  reply	other threads:[~2008-04-28 22:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-28 22:06 [NETFILTER 00/03]: Netfilter fixes Patrick McHardy
2008-04-28 22:06 ` Patrick McHardy [this message]
2008-04-28 22:06 ` [NETFILTER 02/03]: x_tables: fix net namespace leak when reading /proc/net/xxx_tables_names Patrick McHardy
2008-04-28 22:06 ` [NETFILTER 03/03]: {nfnetlink,ip,ip6}_queue: fix skb_over_panic when enlarging packets Patrick McHardy
2008-04-29 10:16 ` [NETFILTER 00/03]: Netfilter fixes David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080428220645.18270.96401.sendpatchset@localhost.localdomain \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.