All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Simner <djs203@srcf.ucam.org>
To: linux-kernel@vger.kernel.org
Cc: mingo@elte.hu
Subject: [patch] sched_info_switch not being called according to documentation (10545)
Date: Tue, 29 Apr 2008 10:08:59 +0100	[thread overview]
Message-ID: <20080429090859.GA16568@srcf.ucam.org> (raw)

Hi,

http://bugzilla.kernel.org/show_bug.cgi?id=10545

sched_stats.h says that __sched_info_switch is "called when prev !=
next" in the comment.  sched.c should therefore do that, see the patch
below:

David

--- linux-2.6.25-old/kernel/sched.c	2008-04-17 03:49:44.000000000 +0100
+++ linux-2.6.25/kernel/sched.c	2008-04-29 10:54:11.000000000 +0100
@@ -3944,9 +3944,9 @@
 	prev->sched_class->put_prev_task(rq, prev);
 	next = pick_next_task(rq, prev);
 
-	sched_info_switch(prev, next);
-
 	if (likely(prev != next)) {
+		sched_info_switch(prev, next);
+
 		rq->nr_switches++;
 		rq->curr = next;
 		++*switch_count;

             reply	other threads:[~2008-04-29  9:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-29  9:08 David Simner [this message]
2008-04-29  9:51 ` [patch] sched_info_switch not being called according to documentation (10545) Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080429090859.GA16568@srcf.ucam.org \
    --to=djs203@srcf.ucam.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.