All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <Uwe.Kleine-Koenig@digi.com>
To: David Brownell <david-b@pacbell.net>
Cc: Alessandro Zummo <a.zummo@towertech.it>, <linux-kernel@vger.kernel.org>
Subject: Re: rtc_valid_tm doesn't check tm_wday
Date: Tue, 29 Apr 2008 14:22:45 +0200	[thread overview]
Message-ID: <20080429122245.GB2137@digi.com> (raw)
In-Reply-To: <200804290340.16642.david-b@pacbell.net>

Hello Dave,

David Brownell wrote:
> On Monday 28 April 2008, Uwe Kleine-König wrote:
> > Hello,
> > 
> > I'm currently writing an rtc driver and want to use rtc_valid_tm to
> > assert to have a valid date before writing it to the rtc.
> > 
> > Now I wonder why rtc_valid_tm doesn't check tm_wday for being in the
> > range [0 .. 6].  Is there a reason?
> 
> As far as I know, the kernel doesn't use tm_wday, tm_yday, or
> tm_isdst ... so none of those fields are expected to be valid.
> See the rtc(4) manpage.
Thanks.

I still want to write the correct value to the rtc, so I will assert
dirctly in the driver that it's valid.

Best regards,
Uwe

-- 
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962

      reply	other threads:[~2008-04-29 12:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-29  6:44 rtc_valid_tm doesn't check tm_wday Uwe Kleine-König
2008-04-29 10:40 ` David Brownell
2008-04-29 12:22   ` Uwe Kleine-König [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080429122245.GB2137@digi.com \
    --to=uwe.kleine-koenig@digi.com \
    --cc=a.zummo@towertech.it \
    --cc=david-b@pacbell.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.