From: Jens Axboe <jens.axboe@oracle.com>
To: "Alan D. Brunelle" <Alan.Brunelle@hp.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Skip I/O merges when disabled
Date: Tue, 29 Apr 2008 14:44:27 +0200 [thread overview]
Message-ID: <20080429124427.GP12774@kernel.dk> (raw)
In-Reply-To: <481715E7.2070103@hp.com>
On Tue, Apr 29 2008, Alan D. Brunelle wrote:
>
> The block I/O + elevator + I/O scheduler code spend a lot of time trying
> to merge I/Os -- rightfully so under "normal" circumstances. However,
> if one were to know that the incoming I/O stream was /very/ random in
> nature, the cycles are wasted.
>
> This patch adds a per-request_queue tunable that (when set) disables
> merge attempts (beyond the simple one-hit cache check), thus freeing up
> a non-trivial amount of CPU cycles.
Thanks Alan, applied. Made one little change (since I had to hand apply
the patch anyway):
> +static ssize_t queue_nomerges_show(struct request_queue *q, char *page)
> +{
> + int nm = test_bit(QUEUE_FLAG_NOMERGES, &q->queue_flags);
> + return queue_var_show(nm, page);
> +}
static ssize_t queue_nomerges_show(struct request_queue *q, char *page)
{
return queue_var_show(blk_queue_nomerges(q), page);
}
--
Jens Axboe
prev parent reply other threads:[~2008-04-29 12:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-29 12:34 [PATCH] Skip I/O merges when disabled Alan D. Brunelle
2008-04-29 12:44 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080429124427.GP12774@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=Alan.Brunelle@hp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.