From: Ingo Molnar <mingo@elte.hu>
To: David Miller <davem@davemloft.net>
Cc: tglx@linutronix.de, torvalds@linux-foundation.org,
harvey.harrison@gmail.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bitops: remove "optimizations"
Date: Tue, 29 Apr 2008 16:20:39 +0200 [thread overview]
Message-ID: <20080429142039.GD26461@elte.hu> (raw)
In-Reply-To: <20080429.053412.15412725.davem@davemloft.net>
* David Miller <davem@davemloft.net> wrote:
> From: David Miller <davem@davemloft.net>
> Date: Tue, 29 Apr 2008 03:03:32 -0700 (PDT)
>
> > From: Thomas Gleixner <tglx@linutronix.de>
> > Date: Tue, 29 Apr 2008 12:01:02 +0200 (CEST)
> >
> > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> >
> > Acked-by: David S. Miller <davem@davemloft.net>
>
> Ironically, I just bisected sparc64 bootup failures to the following
> changeset. It's very late here, and I haven't looked into the
> details, but it seems to wedge in free_area_init_nodes() on a non-NUMA
> system with CONFIG_NUMA disabled.
hm. I guess the next thing you plan to check is whether Thomas's patch
fixes it?
> Isn't it funny that this optimization not only was useless, but also
> broke things. :-/
yeah and sorry :-/ It would still be nice to understand why this
happened, it looks like a weird (and unexpected) interaction.
Ingo
next prev parent reply other threads:[~2008-04-29 14:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-27 20:19 [PATCH] bitops: simplify generic bit finding functions Harvey Harrison
2008-04-27 20:26 ` Linus Torvalds
2008-04-27 20:29 ` Harvey Harrison
2008-04-27 20:36 ` Al Viro
2008-04-27 20:38 ` Harvey Harrison
2008-04-27 20:38 ` Linus Torvalds
2008-04-27 21:02 ` Al Viro
2008-04-28 14:04 ` Thomas Gleixner
2008-04-28 15:10 ` Alexander van Heukelum
2008-04-28 15:58 ` Thomas Gleixner
2008-04-28 16:25 ` Linus Torvalds
2008-04-28 16:47 ` Thomas Gleixner
2008-04-28 16:54 ` Linus Torvalds
2008-04-28 19:26 ` Thomas Gleixner
2008-04-28 19:37 ` Linus Torvalds
2008-04-28 21:55 ` Ingo Molnar
2008-04-29 10:01 ` [PATCH] bitops: remove "optimizations" Thomas Gleixner
2008-04-29 10:03 ` David Miller
2008-04-29 12:34 ` David Miller
2008-04-29 14:20 ` Ingo Molnar [this message]
2008-04-29 22:31 ` David Miller
2008-04-29 16:51 ` Thomas Gleixner
2008-04-29 22:58 ` David Miller
2008-04-29 23:30 ` David Miller
2008-04-28 19:57 ` [PATCH] bitops: simplify generic bit finding functions Andi Kleen
2008-04-28 14:58 ` Alexander van Heukelum
2008-04-28 14:32 ` Alexander van Heukelum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080429142039.GD26461@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.