From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: auke-jan.h.kok@intel.com, netdev@vger.kernel.org
Subject: Error handling corner case found during audits
Date: Tue, 29 Apr 2008 14:31:19 +0100 [thread overview]
Message-ID: <20080429143119.4ef252d6@core> (raw)
Not sure what should happen here.
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.25-mm1/drivers/net/e1000e/ethtool.c linux-2.6.25-mm1/drivers/net/e1000e/ethtool.c
--- linux.vanilla-2.6.25-mm1/drivers/net/e1000e/ethtool.c 2008-04-28 11:36:49.000000000 +0100
+++ linux-2.6.25-mm1/drivers/net/e1000e/ethtool.c 2008-04-18 16:42:41.000000000 +0100
@@ -494,6 +494,8 @@
for (i = 0; i < last_word - first_word + 1; i++) {
ret_val = e1000_read_nvm(hw, first_word + i, 1,
&eeprom_buff[i]);
+ /* ERROR: This path leaves eeprom_buf containing
+ old kernel bytes we then byteswap/return */
if (ret_val)
break;
}
next reply other threads:[~2008-04-29 13:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-29 13:31 Alan Cox [this message]
2008-04-29 18:18 ` [PATCH] Re: Error handling corner case found during audits Kok, Auke
2008-05-06 16:40 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080429143119.4ef252d6@core \
--to=alan@lxorguk.ukuu.org.uk \
--cc=auke-jan.h.kok@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.