From: David Chinner <dgc@sgi.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: David Chinner <dgc@sgi.com>,
linux-next@vger.kernel.org, xfs-masters@oss.sgi.com,
Christoph Hellwig <hch@infradead.org>,
Lachlan McIlroy <lachlan@sgi.com>,
LKML <linux-kernel@vger.kernel.org>,
Linus <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: linux-next: xfs build failure
Date: Wed, 30 Apr 2008 16:35:44 +1000 [thread overview]
Message-ID: <20080430063544.GA108924158@sgi.com> (raw)
In-Reply-To: <20080430140027.6cd83fd0.sfr@canb.auug.org.au>
On Wed, Apr 30, 2008 at 02:00:27PM +1000, Stephen Rothwell wrote:
> Hi all,
>
> Today's linux-next build (powerpc ppc64_defconfig) fails like this:
>
> fs/xfs/xfs_ialloc.c: In function 'xfs_ialloc_ag_alloc':
> fs/xfs/xfs_ialloc.c:301: error: implicit declaration of function 'random32'
>
> I added
>
> #include <linux/random.h>
>
> after the other includes in fs/xfs/xfs_ialloc.c, but there is probably a
> better fix.
>
> The commit that seems to have caused this
> 6309a0720469beb77e0ab75f403a98a0aba4140c ("XFS] Don't initialise new
> inode generation numbers to zero") in the xfs tree that I have seems to
> have just gone into Linus' tree as commit
> 359346a9655c8800408ed3ca44517ac7ea95c197.
Ah, I see the problem - a CONFIG_XFS_DEBUG build includes linux/random.h
in a debug header file. That's probably why I didn't catch it (I need to
check the .config on my build test tree).
I'll get it fixed properly, but in the mean time the include you've got
there will suffice...
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
next prev parent reply other threads:[~2008-04-30 6:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 4:00 linux-next: xfs build failure Stephen Rothwell
2008-04-30 6:35 ` David Chinner [this message]
2008-04-30 6:42 ` Stephen Rothwell
2008-04-30 7:11 ` [PATCH, XFS] Fix random.h include for non-debug builds David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080430063544.GA108924158@sgi.com \
--to=dgc@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=lachlan@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
--cc=xfs-masters@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.