From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Brownell Subject: Re: [patch 2.6.25-git] spi_mpc83xx much improved driver Date: Wed, 30 Apr 2008 15:55:33 -0700 Message-ID: <200804301555.34110.david-b@pacbell.net> References: <200804301537.07965.david-b@pacbell.net> <20080430154631.b86797de.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, 12o3l-IWqWACnzNjzz+pZb47iToQ@public.gmane.org, joakim.tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org, linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org To: Andrew Morton Return-path: In-Reply-To: <20080430154631.b86797de.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Wednesday 30 April 2008, Andrew Morton wrote: > > +=A0=A0=A0=A0=A0spin_lock_irq(&mpc83xx_spi->lock); > = > irq-safe. > = > > ... > > > > +=A0=A0=A0=A0=A0spin_lock(&mpc83xx_spi->lock); > = > not irq-safe. > = > Deliberate? That latter one is inside an #if 0/#endif block, so it won't matter. The #if 0 block bothered me. Maybe Joakim can remove it. (By the way, I'd feel safer about this patch if there were an ack or two from more PPC folk...) ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference = Don't miss this year's exciting event. There's still time to save $100. = Use priority code J8TL2D2. = http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/java= one From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp115.sbc.mail.sp1.yahoo.com (smtp115.sbc.mail.sp1.yahoo.com [69.147.64.88]) by ozlabs.org (Postfix) with SMTP id B2C22DDEF4 for ; Thu, 1 May 2008 08:55:37 +1000 (EST) From: David Brownell To: Andrew Morton Subject: Re: [patch 2.6.25-git] spi_mpc83xx much improved driver Date: Wed, 30 Apr 2008 15:55:33 -0700 References: <200804301537.07965.david-b@pacbell.net> <20080430154631.b86797de.akpm@linux-foundation.org> In-Reply-To: <20080430154631.b86797de.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Message-Id: <200804301555.34110.david-b@pacbell.net> Cc: spi-devel-general@lists.sourceforge.net, 12o3l@tiscali.nl, linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wednesday 30 April 2008, Andrew Morton wrote: > > +     spin_lock_irq(&mpc83xx_spi->lock); > > irq-safe. > > > ... > > > > +     spin_lock(&mpc83xx_spi->lock); > > not irq-safe. > > Deliberate? That latter one is inside an #if 0/#endif block, so it won't matter. The #if 0 block bothered me. Maybe Joakim can remove it. (By the way, I'd feel safer about this patch if there were an ack or two from more PPC folk...)