From: Ingo Molnar <mingo@elte.hu>
To: David Miller <davem@davemloft.net>
Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [patch] net: ipv6 build fix
Date: Wed, 30 Apr 2008 22:38:39 +0200 [thread overview]
Message-ID: <20080430203839.GA19203@elte.hu> (raw)
In-Reply-To: <20080430.013138.157977693.davem@davemloft.net>
hi David,
* David Miller <davem@davemloft.net> wrote:
> net: Several cleanups for the setsockopt compat support.
> net: Add compat support for getsockopt (MCAST_MSFILTER)
this broke !COMPAT builds in current -git. Fix below. NOTE: fix is just
a quick guess.
Ingo
----------------------->
Subject: net: ipv6 build fix
From: Ingo Molnar <mingo@elte.hu>
Date: Wed Apr 30 22:32:09 CEST 2008
x86.git testing found the following build error on -git:
ERROR: "compat_mc_getsockopt" [net/ipv6/ipv6.ko] undefined!
with this config:
http://redhat.com/~mingo/misc/config-Wed_Apr_30_22_23_37_CEST_2008.bad
this hits on !COMPAT + IPV6 modular builds. It is caused by commit
42908c69f6 ("net: Add compat support for getsockopt (MCAST_MSFILTER)").
this fix here is just a quick guess - i _suspect_ that
do_ipv6_getsockopt() will just DTRT and return -EINVAL but i
havent checked. It obviously solves the build issue.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
net/ipv6/ipv6_sockglue.c | 2 ++
1 file changed, 2 insertions(+)
Index: linux/net/ipv6/ipv6_sockglue.c
===================================================================
--- linux.orig/net/ipv6/ipv6_sockglue.c
+++ linux/net/ipv6/ipv6_sockglue.c
@@ -1089,9 +1089,11 @@ int ipv6_getsockopt(struct sock *sk, int
if(level != SOL_IPV6)
return -ENOPROTOOPT;
+#ifdef CONFIG_COMPAT
if (optname == MCAST_MSFILTER)
return compat_mc_getsockopt(sk, level, optname, optval, optlen,
ipv6_getsockopt);
+#endif
err = do_ipv6_getsockopt(sk, level, optname, optval, optlen);
#ifdef CONFIG_NETFILTER
next prev parent reply other threads:[~2008-04-30 20:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 8:31 [GIT]: Networking David Miller
2008-04-30 20:38 ` Ingo Molnar [this message]
2008-04-30 21:17 ` [patch] net: ipv6 build fix David Stevens
2008-04-30 21:29 ` Ingo Molnar
2008-04-30 21:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080430203839.GA19203@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.