From: Ben Hutchings <bhutchings@solarflare.com>
To: David Miller <davem@davemloft.net>
Cc: Kieran Mansley <kmansley@solarflare.com>,
Stephen Hemminger <shemminger@vyatta.com>,
netdev@vger.kernel.org
Subject: [PATCH 0/2] Disable forwarding of LRO skbs
Date: Wed, 30 Apr 2008 22:48:46 +0100 [thread overview]
Message-ID: <20080430214845.GC14219@solarflare.com> (raw)
Large Receive Offload (LRO) destroys packet headers that should be
preserved when forwarding. Currently it also triggers a BUG() or WARN()
in skb_gso_segment(). We should disable it wherever forwarding is
enabled, and discard LRO skbs with a warning if it is turned back on.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
next reply other threads:[~2008-04-30 21:48 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 21:48 Ben Hutchings [this message]
2008-04-30 21:51 ` [PATCH 1/2] Disable forwarding of LRO skbs Ben Hutchings
2008-05-01 9:51 ` David Miller
2008-04-30 21:54 ` [PATCH 2/2] " Ben Hutchings
2008-04-30 21:58 ` [PATCH 0/2] " David Miller
2008-05-01 10:19 ` Herbert Xu
2008-05-01 10:34 ` David Miller
2008-05-01 10:38 ` Herbert Xu
2008-05-01 10:45 ` Herbert Xu
2008-05-01 10:52 ` David Miller
2008-05-01 10:55 ` Herbert Xu
2008-05-01 11:04 ` Kieran Mansley
2008-05-01 10:51 ` David Miller
2008-05-01 10:53 ` Herbert Xu
2008-05-01 11:00 ` Kieran Mansley
2008-05-01 11:06 ` Herbert Xu
2008-05-01 10:42 ` Herbert Xu
2008-05-01 11:02 ` Ben Hutchings
2008-05-01 11:08 ` Kieran Mansley
2008-05-01 11:12 ` Herbert Xu
2008-05-01 11:18 ` Kieran Mansley
2008-05-01 11:37 ` Herbert Xu
2008-05-01 12:08 ` Ben Hutchings
2008-05-01 12:19 ` Herbert Xu
2008-05-12 14:48 ` Ben Hutchings
2008-05-01 14:06 ` Herbert Xu
2008-06-15 0:51 ` Ben Hutchings
2008-06-15 1:46 ` Ben Hutchings
2008-06-15 3:38 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080430214845.GC14219@solarflare.com \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=kmansley@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.