All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: Andres Freund <andres@anarazel.de>
Cc: linux-kernel@vger.kernel.org, apdim@grecian.net,
	Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [PATCH] v4l/dvb: Add linux/version.h include as KERNEL_VERSION macro is used.
Date: Thu, 1 May 2008 01:50:03 -0700	[thread overview]
Message-ID: <20080501015003.4b7a9058@infradead.org> (raw)
In-Reply-To: <200805012005.42400.andres@anarazel.de>

On Thu, 1 May 2008 20:05:41 +0200
Andres Freund <andres@anarazel.de> wrote:

> Whitout this build fails with unknown macro on 
> e4c576b911e364737b1bf4f5bfdab1c440713f26
> 
> Hopefully I did everything correct, as this is my first usage of git
> beside checking out. Also its my first patch on lk....
> 
> Is an Signed-off-by already appropriate with such an trivial change?
> 

Hi,

maybe the real fix is to remove the use of KERNEL_VERSION in this code??

Greetings,
   Arjan van de Ven

  reply	other threads:[~2008-05-02  6:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-01 18:05 [PATCH] v4l/dvb: Add linux/version.h include as KERNEL_VERSION macro is used Andres Freund
2008-05-01  8:50 ` Arjan van de Ven [this message]
2008-05-02 10:15   ` Mauro Carvalho Chehab
2008-05-01 19:31 ` Adrian Bunk
2008-05-01 19:36   ` Andres Freund
2008-05-01 19:45     ` Adrian Bunk
2008-05-01 20:38       ` Andres Freund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080501015003.4b7a9058@infradead.org \
    --to=arjan@infradead.org \
    --cc=andres@anarazel.de \
    --cc=apdim@grecian.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.