From: Al Viro <viro@ZenIV.linux.org.uk>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Harvey Harrison <harvey.harrison@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 09/10] misc: fix returning void-valued expression warnings
Date: Thu, 1 May 2008 13:00:16 +0100 [thread overview]
Message-ID: <20080501120016.GV5882@ZenIV.linux.org.uk> (raw)
In-Reply-To: <4819ACF6.9000403@panasas.com>
On Thu, May 01, 2008 at 02:43:50PM +0300, Boaz Harrosh wrote:
> I don't know who invented sparse, but I like this form of return.
> 1 - It saves me the curly brackets and extra return line. But mainly
> 2 - It is a programing statement that says: "Me here I'm an equivalent
> to that other call". So if in the future that inner function starts
> to return, say, an error value, with the first style the compiler will
> error. But with the second style the new error return will be silently
> ignored. So these are not equivalent replacements. The former is a much
> stronger bond between the caller and the callie.
3. 6.8.6.4(1): A return statement with an expression shall not appear in
a function whose return type is void.
Write in C, please.
next prev parent reply other threads:[~2008-05-01 12:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 22:03 [PATCH 09/10] misc: fix returning void-valued expression warnings Harvey Harrison
2008-05-01 11:43 ` Boaz Harrosh
2008-05-01 12:00 ` Al Viro [this message]
2008-05-01 12:17 ` Peter Zijlstra
2008-05-01 12:51 ` Al Viro
2008-05-01 21:27 ` David Miller
2008-05-01 12:42 ` Boaz Harrosh
2008-05-01 12:53 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080501120016.GV5882@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=bharrosh@panasas.com \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.