Re: Btrfs v0.14 Released

[Chris Mason <chris.mason@oracle.com>]

On Thursday 01 May 2008, Jeff Schroeder wrote:
> On Thu, May 1, 2008 at 9:04 AM, Chris Mason <chris.mason@oracle.com> wrote:
> > On Tuesday 29 April 2008, Chris Mason wrote:
> >  > Hello everyone,
> >  >
> >  > Btrfs v0.14 is now available for download.  Please note the disk
> >  > format has changed, and it is not compatible with older versions of
> >  > Btrfs.
> >  >
> >  > For downloads and documention, please see the Btrfs project page:
> >  >
> >  > http://btrfs.wiki.kernel.org
> >
> >  Hello everyone,
> >
> >  I've rolled up some fixes for older kernels and fixed an uninitialized
> >  variables in btrfs-progs that could cause an oops on mount.  I'll wait a
> > few days to see if other bug reports come in and cut a 0.15 with any
> > other critical fixes.
>
> Well it oopses on writes everytime in Ubuntu 8.04 (Hardy). I'd planned
> on digging into
> it more before spending a bug report, but will send it tonight after
> getting to the affected
> machine.

This is because ubuntu kernels ship with apparmor, you'll need this patch:

If there is a #ifdef IM_A_UBUNTU_KERNEL I can use, I'll do it.  Jeff Mahoney 
has a similar patch for SUSE that I've been meaning to merge, but I wanted to 
lookup some way to check for ubuntu as well.

-chris

diff -r e7da2489b19b file.c
--- a/file.c	Wed Apr 30 13:59:35 2008 -0400
+++ b/file.c	Thu May 01 12:25:11 2008 -0400
@@ -852,7 +852,7 @@ static ssize_t btrfs_file_write(struct f
 		goto out_nolock;
 	if (count == 0)
 		goto out_nolock;
-	err = remove_suid(fdentry(file));
+	err = remove_suid(&file->f_path);
 	if (err)
 		goto out_nolock;
 	file_update_time(file);