From: Ralf Baechle <ralf@linux-mips.org>
To: Daniel Walker <dwalker@mvista.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
johnstul@us.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clocksource: shift helper
Date: Thu, 1 May 2008 22:05:36 +0100 [thread overview]
Message-ID: <20080501210536.GA6135@linux-mips.org> (raw)
In-Reply-To: <1209671305.12461.262.camel@localhost.localdomain>
On Thu, May 01, 2008 at 12:48:25PM -0700, Daniel Walker wrote:
> > If we expect this to have more than one callsite then it would be best to
> > uninline it.
> >
> > Unless we always expect it to be called from __init code, in which case
> > it's best to inline it ;)
>
> I expect it would always get called from __init flagged functions. The
> clocksource can't get registed/used with out the shift and mult values.
>
> If we did uninline this one, we would have to do the other helpers too.
> I imagine the use case is the same for all of them ..
I could imagine this being called for hotpluggable CPUs or nodes, so rather
__cpuinit than __init.
Ralf
next prev parent reply other threads:[~2008-05-01 21:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-01 17:31 [PATCH] clocksource: shift helper Daniel Walker
2008-05-01 19:32 ` Andrew Morton
2008-05-01 19:48 ` Daniel Walker
2008-05-01 21:05 ` Ralf Baechle [this message]
2008-05-06 0:52 ` Thomas Gleixner
2008-05-06 16:39 ` Daniel Walker
2008-05-06 20:25 ` Thomas Gleixner
2008-05-06 20:33 ` Daniel Walker
2008-05-06 20:53 ` Thomas Gleixner
2008-05-06 21:01 ` Daniel Walker
2008-05-06 21:18 ` Andrew Morton
2008-05-06 21:21 ` Thomas Gleixner
2008-05-06 21:19 ` Thomas Gleixner
2008-05-06 21:30 ` Daniel Walker
2008-05-07 16:23 ` Atsushi Nemoto
2008-05-07 3:57 ` Roman Zippel
2008-05-08 16:48 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080501210536.GA6135@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=akpm@linux-foundation.org \
--cc=dwalker@mvista.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.