From: Chandra Seetharaman <sekharan@us.ibm.com>
To: linux-scsi@vger.kernel.org
Cc: dm-devel@redhat.com, andmike@us.ibm.com, michaelc@cs.wisc.edu,
agk@redhat.com, James.Bottomley@HansenPartnership.com,
jens.axboe@oracle.com, dwysocha@redhat.com,
Benoit_Arthur@emc.com, asson_ronald@emc.com,
Chandra Seetharaman <sekharan@us.ibm.com>
Subject: [PATCH 06/10] scsi_dh: Do not allow arguments for hardware handlers
Date: Thu, 01 May 2008 14:50:17 -0700 [thread overview]
Message-ID: <20080501215017.27759.37314.sendpatchset@chandra-ubuntu> (raw)
In-Reply-To: <20080501214941.27759.95121.sendpatchset@chandra-ubuntu>
Subject: [PATCH 06/10] scsi_dh: Do not allow arguments for hardware handlers
From: Chandra Seetharaman <sekharan@us.ibm.com>
The new implementation does not use the arguments provided with the
hardware handler. This patch makes the change visible to the user by
failing table load when arguments are provided with the hardware handler.
Signed-off-by: Chandra Seetharaman <sekharan@us.ibm.com>
---
Index: linux-2.6.25/drivers/md/dm-mpath.c
===================================================================
--- linux-2.6.25.orig/drivers/md/dm-mpath.c
+++ linux-2.6.25/drivers/md/dm-mpath.c
@@ -653,11 +653,15 @@ static int parse_hw_handler(struct arg_s
struct dm_target *ti = m->ti;
static struct param _params[] = {
- {0, 1024, "invalid number of hardware handler args"},
+ {0, 1, "invalid number of hardware handler args"},
};
- if (read_param(_params, shift(as), &hw_argc, &ti->error))
+ if (read_param(_params, shift(as), &hw_argc, &ti->error)) {
+ if (hw_argc > 1)
+ ti->error = "no arguments accepted for hardware"
+ " handler";
return -EINVAL;
+ }
if (!hw_argc)
return 0;
next prev parent reply other threads:[~2008-05-01 21:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-01 21:49 [PATCH 00/10] scsi_dh: Move hardware handlers from dm to SCSI Chandra Seetharaman
2008-05-01 21:49 ` [PATCH 01/10] scsi_dh: add infrastructure for SCSI Device Handlers Chandra Seetharaman
2008-05-01 21:49 ` [PATCH 02/10] scsi_dh: add lsi rdac device handler Chandra Seetharaman
2008-05-01 21:49 ` [PATCH 03/10] scsi_dh: add hp sw " Chandra Seetharaman
2008-05-01 21:50 ` [PATCH 04/10] scsi_dh: add EMC Clariion " Chandra Seetharaman
2008-05-01 21:50 ` [PATCH 05/10] scsi_dh: Use SCSI device handler in dm-multipath Chandra Seetharaman
2008-05-01 21:50 ` Chandra Seetharaman [this message]
2008-05-02 22:47 ` [PATCH 06/10] scsi_dh: Do not allow arguments for hardware handlers Alasdair G Kergon
2008-05-03 0:01 ` [dm-devel] " Chandra Seetharaman
2008-05-01 21:50 ` [PATCH 07/10] scsi_dh: Add a single threaded workqueue for initializing paths Chandra Seetharaman
2008-05-01 21:50 ` [PATCH 08/10] scsi_dh: Remove dm_pg_init_complete Chandra Seetharaman
2008-05-01 21:50 ` [PATCH 09/10] scsi_dh: Remove hardware handlers from dm Chandra Seetharaman
2008-05-01 21:50 ` [PATCH 10/10] scsi_dh: Remove hardware handler infrastructure " Chandra Seetharaman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080501215017.27759.37314.sendpatchset@chandra-ubuntu \
--to=sekharan@us.ibm.com \
--cc=Benoit_Arthur@emc.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=agk@redhat.com \
--cc=andmike@us.ibm.com \
--cc=asson_ronald@emc.com \
--cc=dm-devel@redhat.com \
--cc=dwysocha@redhat.com \
--cc=jens.axboe@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.