All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: fubar@us.ibm.com
Cc: netdev@vger.kernel.org, jgarzik@pobox.com
Subject: Re: [PATCH REPOST 4/4] bonding: fix enslavement error unwinds
Date: Fri, 02 May 2008 18:07:21 -0700 (PDT)	[thread overview]
Message-ID: <20080502.180721.97386451.davem@davemloft.net> (raw)
In-Reply-To: <21092.1209776762@death>

From: Jay Vosburgh <fubar@us.ibm.com>
Date: Fri, 02 May 2008 18:06:02 -0700

> 
> 	As part of:
> 
> commit c2edacf80e155ef54ae4774379d461b60896bc2e
> Author: Jay Vosburgh <fubar@us.ibm.com>
> Date:   Mon Jul 9 10:42:47 2007 -0700
> 
>     bonding / ipv6: no addrconf for slaves separately from master
> 
> two steps were rearranged in the enslavement process: netdev_set_master
> is now before the call to dev_open to open the slave.
> 
> 	This patch updates the error cases and unwind process at the
> end of bond_enslave to match the new order.  Without this patch, it is
> possible for the enslavement to fail, but leave the slave with IFF_SLAVE
> set in its flags.
> 
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>

Thanks for fixing up the commit message:

Acked-by: David S. Miller <davem@davemloft.net>

  reply	other threads:[~2008-05-03  1:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-03  0:49 [PATCH 0/4] bonding: bug fixes for 2.6.26 Jay Vosburgh
2008-05-03  0:49 ` [PATCH 1/4] bonding: Do not call free_netdev for already registered device Jay Vosburgh
2008-05-03  0:49   ` [PATCH 2/4] bonding: fix error unwind in bonding_store_bonds Jay Vosburgh
2008-05-03  0:49     ` [PATCH 3/4] bonding: Deadlock between bonding_store_bonds and bond_destroy_sysfs Jay Vosburgh
2008-05-03  0:49       ` [PATCH 4/4] bonding: fix enslavement error unwinds Jay Vosburgh
2008-05-03  0:52         ` David Miller
2008-05-03  1:06           ` [PATCH REPOST " Jay Vosburgh
2008-05-03  1:07             ` David Miller [this message]
2008-05-03  0:51       ` [PATCH 3/4] bonding: Deadlock between bonding_store_bonds and bond_destroy_sysfs David Miller
2008-05-03  0:51     ` [PATCH 2/4] bonding: fix error unwind in bonding_store_bonds David Miller
2008-05-03  0:51   ` [PATCH 1/4] bonding: Do not call free_netdev for already registered device David Miller
2008-05-06 16:17   ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080502.180721.97386451.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=fubar@us.ibm.com \
    --cc=jgarzik@pobox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.