From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763195AbYEBBmQ (ORCPT ); Thu, 1 May 2008 21:42:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756794AbYEBBmA (ORCPT ); Thu, 1 May 2008 21:42:00 -0400 Received: from cantor2.suse.de ([195.135.220.15]:58465 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756735AbYEBBl7 (ORCPT ); Thu, 1 May 2008 21:41:59 -0400 Date: Fri, 2 May 2008 03:41:55 +0200 From: Nick Piggin To: Hugh Dickins Cc: =?iso-8859-1?Q?J=2EA=2E_Magall=F3n?= , Jens Axboe , Linux-Kernel Subject: Re: Problems with -git14 Message-ID: <20080502014155.GG30768@wotan.suse.de> References: <20080430015655.5a42f63d@werewolf.home> <20080501025043.5e8582f6@werewolf.home> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 01, 2008 at 01:11:51PM +0100, Hugh Dickins wrote: > On Thu, 1 May 2008, J.A. Magallón wrote: > > On Wed, 30 Apr 2008 16:17:46 +0100 (BST), Hugh Dickins wrote: > > > On Wed, 30 Apr 2008, J.A. Magallón wrote: > > > > > > > > I have a couple problems with latest git (-14): > > > > > > > > - It only recognises 2 processors out of 4 (dual Xeon HT) > > > > - It oopses on the swapper process just on boot... > > > > > > > > Difference in dmesg is below. If full correct dmesg or config is > > > > needed, please ask for them. The kernel was built copying old > > > > 2.6.25 config to .config && make oldconfig. I filled the missing > > > > gaps like PAT and others... > ... > > > > +WARNING: at include/linux/blkdev.h:427 blk_queue_init_tags+0x110/0x11f() > > > > > > I presume this warning and backtrace is what you report as an oops: > > > I think you'll find Linus included a fix for this one overnight, and > > > it should have gone away in 2.6.25-git15 (but I didn't see it myself). > > > > -git16 plus your patch gives me my 4 cpus again. > > I'm glad to hear this, thanks. > > > But I still get the warning: > > But sorry to hear this. That warning has undergone several revisions > already: I expect yours is another false positive not to worry about, > but it still needs to be fixed. I won't meddle in there, Cc'ed Jens > and Nick who will know what's appropriate. Thanks for the heads up Hugh. I think we're OK at this point because we're running in allocation/setup code so there should be no concurrency on queue_flags. I remember following this call chain and making this conclusion (hopefully correct, Jens?)... however I don't know how I concluded that the warning would not fire. > > Hugh > > > > > scsi0 : Adaptec AIC79XX PCI-X SCSI HBA DRIVER, Rev 3.0 > > > > aic7902: Ultra320 Wide Channel A, SCSI Id=7, PCI 33 or 66Mhz, 512 SCBs > > ACPI: PCI Interrupt 0000:03:0a.1[B] -> GSI 23 (level, low) -> IRQ 23 > > scsi1 : Adaptec AIC79XX PCI-X SCSI HBA DRIVER, Rev 3.0 > > > > aic7902: Ultra320 Wide Channel B, SCSI Id=7, PCI 33 or 66Mhz, 512 SCBs > > scsi 1:0:0:0: Direct-Access SEAGATE ST336807LW 0C01 PQ: 0 ANSI: 3 > > ------------[ cut here ]------------ > > WARNING: at include/linux/blkdev.h:431 blk_queue_init_tags+0x110/0x11f() > > Modules linked in: > > Pid: 1, comm: swapper Not tainted 2.6.25-jam03 #1 > > [] warn_on_slowpath+0x4d/0x66 > > [] __atomic_notifier_call_chain+0x27/0x48 > > [] atomic_notifier_call_chain+0x17/0x1b > > [] notify_update+0x1f/0x23 > > [] vt_console_print+0x1dd/0x2ab > > [] vt_console_print+0x0/0x2ab > > [] up+0x9/0x2b > > [] init_tag_map+0x4e/0x95 > > [] __blk_queue_init_tags+0x27/0x4e > > [] blk_queue_init_tags+0x110/0x11f > > [] ahd_platform_set_tags+0x177/0x1a7 > > [] ahd_linux_slave_configure+0xcd/0x131 > > [] scsi_probe_and_add_lun+0x706/0x964 > > [] __scsi_scan_target+0xd9/0x5d9 > > [] sysfs_ilookup_test+0x0/0xd > > [] sysfs_addrm_finish+0x14/0x1c7 > > [] sysfs_find_dirent+0x1e/0x27 > > [] sysfs_add_one+0x3b/0x8b > > [] sysfs_add_file_mode+0x4d/0x76 > > [] internal_create_group+0xd7/0x196 > > [] klist_next+0x53/0x90 > > [] scsi_scan_channel+0x78/0x8d > > [] scsi_scan_host_selected+0xa8/0xd1 > > [] do_scsi_scan_host+0x68/0x6a > > [] ahd_linux_register_host+0x267/0x2db > > [] ahd_pci_map_int+0x2c/0x50 > > [] ahd_pci_config+0x533/0x824 > > [] kobject_get+0xf/0x13 > > [] get_device+0xe/0x14 > > [] pci_dev_get+0xf/0x13 > > [] ahd_linux_pci_dev_probe+0x139/0x17f > > [] sysfs_addrm_finish+0x14/0x1c7 > > [] sysfs_find_dirent+0x1e/0x27 > > [] sysfs_add_one+0x3b/0x8b > > [] sysfs_create_link+0x89/0x106 > > [] pci_match_device+0x9c/0xad > > [] pci_device_probe+0x40/0x60 > > [] driver_probe_device+0x76/0x152 > > [] __driver_attach+0x56/0x58 > > [] bus_for_each_dev+0x39/0x57 > > [] pci_device_probe+0x0/0x60 > > [] driver_attach+0x16/0x1a > > [] __driver_attach+0x0/0x58 > > [] bus_add_driver+0x19c/0x214 > > [] pci_device_remove+0x0/0x36 > > [] pci_device_probe+0x0/0x60 > > [] driver_register+0x3b/0xd3 > > [] __pci_register_driver+0x32/0x64 > > [] ahd_linux_init+0x53/0x6f > > [] kernel_init+0x11d/0x287 > > [] finish_task_switch+0x1f/0x6d > > [] schedule_tail+0x16/0x44 > > [] ret_from_fork+0x6/0x1c > > [] kernel_init+0x0/0x287 > > [] kernel_init+0x0/0x287 > > [] kernel_thread_helper+0x7/0x18 > > ======================= > > ---[ end trace e7ca32af98aeff40 ]--- > > scsi target1:0:0: asynchronous > > scsi1:A:0:0: Tagged Queuing enabled. Depth 32 > > scsi target1:0:0: Beginning Domain Validation > > scsi target1:0:0: wide asynchronous > > scsi target1:0:0: FAST-160 WIDE SCSI 320.0 MB/s DT IU QAS RDSTRM WRFLOW PCOMP (6.25 ns, offset 63) > > scsi target1:0:0: Ending Domain Validation > > scsi 1:0:1:0: Direct-Access SEAGATE ST336807LW 0C01 PQ: 0 ANSI: 3 > > scsi target1:0:1: asynchronous > > scsi1:A:1:0: Tagged Queuing enabled. Depth 32 > > scsi target1:0:1: Beginning Domain Validation > > scsi target1:0:1: wide asynchronous > > scsi target1:0:1: FAST-160 WIDE SCSI 320.0 MB/s DT IU QAS RDSTRM WRFLOW PCOMP (6.25 ns, offset 63) > > scsi target1:0:1: Ending Domain Validation > > Driver 'sd' needs updating - please use bus_type methods > > sd 1:0:0:0: [sda] 71687372 512-byte hardware sectors (36704 MB) > > sd 1:0:0:0: [sda] Write Protect is off > > sd 1:0:0:0: [sda] Mode Sense: ab 00 10 08 > > sd 1:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA > > sd 1:0:0:0: [sda] 71687372 512-byte hardware sectors (36704 MB) > > sd 1:0:0:0: [sda] Write Protect is off > > sd 1:0:0:0: [sda] Mode Sense: ab 00 10 08 > > sd 1:0:0:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA > > sda: sda1 sda2 > > sd 1:0:0:0: [sda] Attached SCSI disk > > sd 1:0:1:0: [sdb] 71687372 512-byte hardware sectors (36704 MB) > > sd 1:0:1:0: [sdb] Write Protect is off > > sd 1:0:1:0: [sdb] Mode Sense: ab 00 10 08 > > sd 1:0:1:0: [sdb] Write cache: enabled, read cache: enabled, supports DPO and FUA > > sd 1:0:1:0: [sdb] 71687372 512-byte hardware sectors (36704 MB) > > sd 1:0:1:0: [sdb] Write Protect is off > > sd 1:0:1:0: [sdb] Mode Sense: ab 00 10 08 > > sd 1:0:1:0: [sdb] Write cache: enabled, read cache: enabled, supports DPO and FUA > > sdb: sdb1 > > sd 1:0:1:0: [sdb] Attached SCSI disk