All of lore.kernel.org
 help / color / mirror / Atom feed
From: Holger Schurig <hs4233@mail.mn-solutions.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: libertas-dev@lists.infradead.org, Dan Williams <dcbw@redhat.com>,
	linux-wireless@vger.kernel.org,
	"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] libertas: reduce command retry time
Date: Fri, 2 May 2008 08:07:44 +0200	[thread overview]
Message-ID: <200805020807.44472.hs4233@mail.mn-solutions.de> (raw)
In-Reply-To: <1209679021.25560.594.camel@pmac.infradead.org>

> > Or: maybe there is another way to make "pccardctl eject"
> > work reasonably fast in the case of a retrying command. Any
> > idea?
>
> Does it set priv->surpriseremoved? We should honour that.

Unfortunately not. Manually ejecting the card sets this (via 
ISR). Then the driver very quickly disables the card, retrying 
commands or not. It's just "pccardctl eject" that can, under 
circumstances, take ages. Unfortunately this circumstances 
happen in my (embedded) hardware setup, e.g. when 
suspending/resuming.

At resume time, I simply do "pccardctl eject" / "pccardctl 
insert" to get the driver correctly initialized again and 
associating. Because doing "real" suspend/resume is currently 
impossible for me with my knowledge of the firmware.


> No, it just waits until the timer has been properly removed.
> If the timer was set for some time in the future, it doesn't
> wait for it to happen naturally.

Oh, this is what I thought would happen. In this case, it 
{c/sh}ould stay at del_timer_sync().

      reply	other threads:[~2008-05-02  6:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-30 14:44 [PATCH] libertas: reduce command retry time Holger Schurig
2008-04-30 20:34 ` Dan Williams
2008-04-30 20:43   ` David Woodhouse
2008-05-01 21:30     ` Holger Schurig
2008-05-01 21:57       ` David Woodhouse
2008-05-02  6:07         ` Holger Schurig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200805020807.44472.hs4233@mail.mn-solutions.de \
    --to=hs4233@mail.mn-solutions.de \
    --cc=dcbw@redhat.com \
    --cc=dwmw2@infradead.org \
    --cc=libertas-dev@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.