Re: [PATCH 3/4] dpt_i2o: 64 bit support

[Rolf Eike Beer <eike-kernel@sf-tec.de>]

[-- Attachment #1: Type: text/plain, Size: 614 bytes --]

Miquel van Smoorenburg wrote:
> [PATCH 3/4] dpt_i2o: 64 bit support
>
> This is the code to actually support 64 bit platforms. 64 bit
> DMA is enabled on both x86_32 PAE and 64 bit platforms.
>
> This code is based in part on the unofficial adaptec 64-bit
> dpt_i2o driver update that I got from Mark Salyzyn at Adaptec.

> +static inline int dpt_dma64(adpt_hba *pHba)
> +{
> +	return (sizeof(dma_addr_t) > 4 && (pHba)->dma64);
> +}
> +

Just a note: you never set dma64 if sizeof(dma_addr_t) == 4. Doing it this way 
has the advantage that the compiler can optimize that away completely.

Eike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 194 bytes --]