From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Rodolfo Giometti <giometti@enneenne.com>
Cc: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
David Woodhouse <dwmw2@infradead.org>,
Dave Jones <davej@redhat.com>, Sam Ravnborg <sam@ravnborg.org>,
Greg KH <greg@kroah.com>, Randy Dunlap <randy.dunlap@oracle.com>,
Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: [PATCH 5/7] PPS: serial clients support.
Date: Fri, 2 May 2008 13:56:18 +0100 [thread overview]
Message-ID: <20080502135618.7172af4a@core> (raw)
In-Reply-To: <20080502104537.GW3002@enneenne.com>
> So I should rewrite the uart_handle_dcd_change() as follow?
>
> static inline void
> uart_handle_dcd_change(struct uart_port *port, unsigned int status)
> {
> struct uart_info *info = port->info;
> struct tty_struct *tty = info->tty;
> struct tty_ldisc *ld;
>
> ld = tty_ldisc_ref(tty);
> if (ld != NULL) {
> if (ld->dcd_change)
> (ld->dcd_change)(tty, port, status);
> tty_ldisc_deref(ld);
> }
>
> port->icount.dcd++;
>
> #ifdef CONFIG_HARD_PPS
> if ((port->flags & UPF_HARDPPS_CD) && status)
> hardpps();
> #endif
The ifdef bit can go - it will be in your dcd_change callback ..
Alan
next prev parent reply other threads:[~2008-05-02 13:05 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 16:01 [PATCH 5/7] PPS: serial clients support Rodolfo Giometti
2008-04-10 16:06 ` Rodolfo Giometti
2008-04-10 17:41 ` Greg KH
2008-04-10 18:22 ` LinuxPPS (RESUBMIT 4): the PPS Linux implementation Rodolfo Giometti
2008-04-10 18:22 ` [PATCH 1/7] LinuxPPS core support Rodolfo Giometti
2008-04-10 18:22 ` [PATCH 2/7] PPS: userland header file for PPS API Rodolfo Giometti
2008-04-10 18:22 ` [PATCH 3/7] PPS: documentation programs and examples Rodolfo Giometti
2008-04-10 18:22 ` [PATCH 4/7] PPS: LinuxPPS clients support Rodolfo Giometti
2008-04-10 18:22 ` [PATCH 5/7] PPS: serial " Rodolfo Giometti
2008-04-10 18:22 ` [PATCH 6/7] PPS: example program to enable PPS support on serial ports Rodolfo Giometti
2008-04-10 18:22 ` [PATCH 7/7] PPS: parallel port clients support Rodolfo Giometti
2008-04-10 20:09 ` [PATCH 5/7] PPS: serial " Alan Cox
2008-04-11 7:55 ` Rodolfo Giometti
2008-04-11 8:28 ` Alan Cox
2008-04-11 8:49 ` Rodolfo Giometti
2008-04-11 14:43 ` Serge Belyshev
2008-04-11 16:58 ` Rodolfo Giometti
2008-04-11 13:47 ` Lennart Sorensen
2008-04-11 14:46 ` Alan Cox
2008-04-30 11:41 ` Rodolfo Giometti
2008-04-30 16:28 ` Alan Cox
2008-05-02 7:33 ` Rodolfo Giometti
2008-05-02 10:18 ` Alan Cox
2008-05-02 10:45 ` Rodolfo Giometti
2008-05-02 12:56 ` Alan Cox [this message]
2008-05-02 21:09 ` Rodolfo Giometti
-- strict thread matches above, loose matches on Subject: below --
2008-04-10 15:15 LinuxPPS (RESUBMIT 3): the PPS Linux implementation Rodolfo Giometti
2008-04-10 15:15 ` [PATCH 1/7] LinuxPPS core support Rodolfo Giometti
2008-04-10 15:15 ` [PATCH 2/7] PPS: userland header file for PPS API Rodolfo Giometti
2008-04-10 15:15 ` [PATCH 3/7] PPS: documentation programs and examples Rodolfo Giometti
2008-04-10 15:15 ` [PATCH 4/7] PPS: LinuxPPS clients support Rodolfo Giometti
2008-04-10 15:15 ` [PATCH 5/7] PPS: serial " Rodolfo Giometti
2008-04-10 15:28 ` Alan Cox
2008-04-10 15:36 ` Rodolfo Giometti
2008-03-06 12:08 LinuxPPS (RESUBMIT 2): the PPS Linux implementation Rodolfo Giometti
2008-03-06 12:09 ` [PATCH 1/7] LinuxPPS core support Rodolfo Giometti
2008-03-06 12:09 ` [PATCH 2/7] PPS: userland header file for PPS API Rodolfo Giometti
2008-03-06 12:09 ` [PATCH 3/7] PPS: documentation programs and examples Rodolfo Giometti
2008-03-06 12:09 ` [PATCH 4/7] PPS: LinuxPPS clients support Rodolfo Giometti
2008-03-06 12:09 ` [PATCH 5/7] PPS: serial " Rodolfo Giometti
2008-03-20 20:04 ` Andrew Morton
2008-03-21 11:17 ` Rodolfo Giometti
2008-03-21 17:41 ` Andrew Morton
2008-03-25 10:38 ` Rodolfo Giometti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080502135618.7172af4a@core \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=davej@redhat.com \
--cc=dwmw2@infradead.org \
--cc=giometti@enneenne.com \
--cc=greg@kroah.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lsorense@csclub.uwaterloo.ca \
--cc=randy.dunlap@oracle.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.