All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rodolfo Giometti <giometti@enneenne.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-kernel@vger.kernel.org, Jaroslav Kysela <perex@suse.cz>,
	James Stafford <jstafford@ampltd.com>,
	Doug McLain <nostar@comcast.net>
Subject: Re: [PATCH] [ALSA] ice1724 - support for more that one codec.
Date: Fri, 2 May 2008 21:52:32 +0200	[thread overview]
Message-ID: <20080502195232.GA8502@enneenne.com> (raw)
In-Reply-To: <s5h4p9jwmhr.wl%tiwai@suse.de>

On Wed, Apr 30, 2008 at 02:33:36PM +0200, Takashi Iwai wrote:
> At Wed, 30 Apr 2008 11:27:18 +0200,
> Rodolfo Giometti wrote:
> > 
> > Now it's possible to specify how many codes are present on the board by
> > using a new filed as follow:
> > 
> > 	ice->ac97_codecs = 4;
> > 
> > For backward compatibility if "ice->ac97_codecs" is set to zero, the patch
> > redefines it as "1".
> > 
> > Signed-off-by: Rodolfo Giometti <giometti@linux.it>
> 
> Thanks for the patch.  The change looks OK to me, but please fix the
> issues reported by checkpatch.pl.

Ok, I'll do it ASAP.

> And, which hardware has multiple AC97 codecs?  I'd like rather apply
> it together.

I'm still working on it since I'd like to record from 4 channels at
time but I can't... here my custom settings:

static unsigned char int1410_eeprom[] __devinitdata = {
        [ICE_EEP1_CODEC]        = 0x1f,
        [ICE_EEP1_ACLINK]       = 0x00,
        [ICE_EEP1_I2SID]        = 0x01,
        [ICE_EEP1_SPDIF]        = 0x03,
        [ICE_EEP1_GPIO_MASK]    = 0xff,
        [ICE_EEP1_GPIO_STATE]   = 0xff,
        [ICE_EEP1_GPIO_DIR]     = 0xff,
};

static int __devinit snd_ice1712_int1410_init(struct snd_ice1712 *ice)
{
        printk("%s\n", __FUNCTION__);

        /* Set the pro AC97 codecs */
        ice->ac97_codecs = 4;

        /* Set the analog DACs/ADCs */
        ice->num_total_dacs = 8;
        ice->num_total_adcs = 8;

        return 0;
}

/* entry point */
struct snd_ice1712_card_info snd_ice1712_eurotech_cards[] __devinitdata =
{
        {
                .subvendor      = ICE1712_SUBDEVICE_INT1410,    /* a dummy id */
                .name           = "Eurotech INT 1410",
                .model          = "int1410",
                .chip_init      = snd_ice1712_int1410_init,
                .build_controls = snd_ice1712_int1410_add_controls,
                .no_mpu401      = 1,
                .eeprom_size    = sizeof(int1410_eeprom),
                .eeprom_data    = int1410_eeprom,
                .driver         = "int1410",
        },
        { } /* terminator */
};

But I'm a bit confused regarding how to enable such feature. Again,
should I use a multitrack audio recorder as ecasound or I can just use
arecord with some magic options? :)

Thanks,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail:    giometti@enneenne.com
Linux Device Driver                             giometti@linux.it
Embedded Systems                     phone:	+39 349 2432127
UNIX programming                     skype:     rodolfo.giometti

      reply	other threads:[~2008-05-02 19:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <s5h8xamsuxd.wl%tiwai@suse.de>
2008-04-30  9:27 ` [PATCH] [ALSA] ice1724 - support for more that one codec Rodolfo Giometti
2008-04-30 12:33   ` Takashi Iwai
2008-05-02 19:52     ` Rodolfo Giometti [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080502195232.GA8502@enneenne.com \
    --to=giometti@enneenne.com \
    --cc=jstafford@ampltd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nostar@comcast.net \
    --cc=perex@suse.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.