From: Cyrill Gorcunov <gorcunov@gmail.com>
To: akpm@linux-foundation.org, hpa@zytor.com, mingo@elte.hu,
ralf@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 4/4] MIPS: ELF handling - use SELFMAG instead of numeric constant
Date: Sat, 3 May 2008 14:35:58 +0400 [thread overview]
Message-ID: <20080503103558.GB6844@cvg> (raw)
In-Reply-To: <481c3f59.0407560a.2d49.ffffbf04@mx.google.com>
[Cyrill Gorcunov - Sat, May 03, 2008 at 02:18:04PM +0400]
| Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
| ---
|
| Index: linux-2.6.git/arch/mips/kernel/vpe.c
| ===================================================================
| --- linux-2.6.git.orig/arch/mips/kernel/vpe.c 2008-04-15 23:01:26.000000000 +0400
| +++ linux-2.6.git/arch/mips/kernel/vpe.c 2008-05-02 21:40:57.000000000 +0400
| @@ -840,7 +840,7 @@ static int vpe_elfload(struct vpe * v)
|
| /* Sanity checks against insmoding binaries or wrong arch,
| weird elf version */
| - if (memcmp(hdr->e_ident, ELFMAG, 4) != 0
| + if (memcmp(hdr->e_ident, ELFMAG, SELFMAG) != 0
| || (hdr->e_type != ET_REL && hdr->e_type != ET_EXEC)
| || !elf_check_arch(hdr)
| || hdr->e_shentsize != sizeof(*sechdrs)) {
|
| --
|
oops, MIPS was not refreshed by whole. This is a fix.
---
From: Cyrill Gorcunov <gorcunov@gmail.com>
Subject: MIPS: ELF handling - use SELFMAG instead of numeric constant
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
Index: linux-2.6.git/arch/mips/kernel/vpe.c
===================================================================
--- linux-2.6.git.orig/arch/mips/kernel/vpe.c 2008-04-15 23:01:26.000000000 +0400
+++ linux-2.6.git/arch/mips/kernel/vpe.c 2008-05-03 14:28:47.000000000 +0400
@@ -840,7 +840,7 @@ static int vpe_elfload(struct vpe * v)
/* Sanity checks against insmoding binaries or wrong arch,
weird elf version */
- if (memcmp(hdr->e_ident, ELFMAG, 4) != 0
+ if (memcmp(hdr->e_ident, ELFMAG, SELFMAG) != 0
|| (hdr->e_type != ET_REL && hdr->e_type != ET_EXEC)
|| !elf_check_arch(hdr)
|| hdr->e_shentsize != sizeof(*sechdrs)) {
@@ -1107,7 +1107,7 @@ static int vpe_release(struct inode *ino
return -ENODEV;
hdr = (Elf_Ehdr *) v->pbuffer;
- if (memcmp(hdr->e_ident, ELFMAG, 4) == 0) {
+ if (memcmp(hdr->e_ident, ELFMAG, SELFMAG) == 0) {
if (vpe_elfload(v) >= 0) {
vpe_run(v);
} else {
next prev parent reply other threads:[~2008-05-03 10:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080503101800.417039810@gmail.com>
2008-05-03 10:18 ` [patch 1/4] x86: vdso ELF handling - use SELFMAG instead of numeric constant Cyrill Gorcunov
2008-05-03 21:06 ` Thomas Gleixner
2008-05-03 10:18 ` [patch 2/4] module loading " Cyrill Gorcunov
2008-05-03 10:18 ` [patch 3/4] x86: relocs " Cyrill Gorcunov
2008-05-03 21:07 ` Thomas Gleixner
2008-05-03 10:18 ` [patch 4/4] MIPS: " Cyrill Gorcunov
2008-05-03 10:35 ` Cyrill Gorcunov [this message]
2008-05-04 16:50 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080503103558.GB6844@cvg \
--to=gorcunov@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.