All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: linux-kernel@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	Ivo van Doorn <ivdoorn@gmail.com>
Subject: [patch/bugreport] rt2x00: build fix
Date: Sat, 3 May 2008 14:47:11 +0200	[thread overview]
Message-ID: <20080503124711.GA18244@elte.hu> (raw)


x86.git testing found the following build failure on latest -git:

   Building modules, stage 2.
   MODPOST 332 modules
 ERROR: "led_classdev_unregister" [drivers/net/wireless/rt2x00/rt2x00lib.ko] undefined!
 ERROR: "led_classdev_resume" [drivers/net/wireless/rt2x00/rt2x00lib.ko] undefined!
 ERROR: "led_classdev_register" [drivers/net/wireless/rt2x00/rt2x00lib.ko] undefined!
 ERROR: "led_classdev_suspend" [drivers/net/wireless/rt2x00/rt2x00lib.ko] undefined!
 make[1]: *** [__modpost] Error 1
 make: *** [modules] Error 2

config can be found at:

  http://redhat.com/~mingo/misc/config-Sat_May__3_13_24_19_CEST_2008.bad

the patch here is just a quick workaround for now for my test-setup, it 
makes the leds features in this driver depend on NEW_LEDS. Have not 
checked how far away this is from the real fix. Hm, and i think think i 
sent another patch for a similar build failure a week ago already - did 
i miss some patch to try?

	Ingo

---
 drivers/net/wireless/rt2x00/Kconfig |    5 +++++
 1 file changed, 5 insertions(+)

Index: linux/drivers/net/wireless/rt2x00/Kconfig
===================================================================
--- linux.orig/drivers/net/wireless/rt2x00/Kconfig
+++ linux/drivers/net/wireless/rt2x00/Kconfig
@@ -61,6 +61,7 @@ config RT2400PCI_RFKILL
 config RT2400PCI_LEDS
 	bool "RT2400 leds support"
 	depends on RT2400PCI
+	depends on NEW_LEDS
 	select LEDS_CLASS
 	select RT2X00_LIB_LEDS
 	---help---
@@ -88,6 +89,7 @@ config RT2500PCI_RFKILL
 config RT2500PCI_LEDS
 	bool "RT2500 leds support"
 	depends on RT2500PCI
+	depends on NEW_LEDS
 	select LEDS_CLASS
 	select RT2X00_LIB_LEDS
 	---help---
@@ -117,6 +119,7 @@ config RT61PCI_RFKILL
 config RT61PCI_LEDS
 	bool "RT61 leds support"
 	depends on RT61PCI
+	depends on NEW_LEDS
 	select LEDS_CLASS
 	select RT2X00_LIB_LEDS
 	---help---
@@ -134,6 +137,7 @@ config RT2500USB
 config RT2500USB_LEDS
 	bool "RT2500 leds support"
 	depends on RT2500USB
+	depends on NEW_LEDS
 	select LEDS_CLASS
 	select RT2X00_LIB_LEDS
 	---help---
@@ -153,6 +157,7 @@ config RT73USB
 config RT73USB_LEDS
 	bool "RT73 leds support"
 	depends on RT73USB
+	depends on NEW_LEDS
 	select LEDS_CLASS
 	select RT2X00_LIB_LEDS
 	---help---

             reply	other threads:[~2008-05-03 12:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-03 12:47 Ingo Molnar [this message]
2008-05-03 13:19 ` [patch/bugreport] rt2x00: build fix Ivo van Doorn
2008-05-03 16:47 ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080503124711.GA18244@elte.hu \
    --to=mingo@elte.hu \
    --cc=davem@davemloft.net \
    --cc=ivdoorn@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.