From: Arnd Bergmann <arnd@arndb.de>
To: monstr@seznam.cz
Cc: paulus@samba.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, Michal Simek <monstr@monstr.eu>
Subject: Re: [PATCH 1/2] OF: Fix coding style violation in of_device.c and of_platform.c
Date: Sat, 3 May 2008 23:04:57 +0200 [thread overview]
Message-ID: <200805032304.58709.arnd@arndb.de> (raw)
In-Reply-To: <765c6c8053679c45eb370255a110f7bc680a8f25.1209824033.git.monstr@monstr.eu>
On Saturday 03 May 2008, monstr@seznam.cz wrote:
>
> #include <asm/errno.h>
> +
> +#ifdef CONFIG_PPC_PSERIES
> #include <asm/dcr.h>
> +#endif
>
The patch looks basically good, but we normally try to not have an #include
inside of #ifdef. If the file builds without this #include, maybe you should
better leave it out entirely? Same for the ppc-pci.h in the other file.
Arnd <><
next prev parent reply other threads:[~2008-05-03 21:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-03 14:22 Moving OF firware to arch independent folder monstr
2008-05-03 14:22 ` [PATCH 1/2] OF: Fix coding style violation in of_device.c and of_platform.c monstr
2008-05-03 14:22 ` [PATCH 2/2] OF: Move of_device.c and of_platform.c to drivers/of/ monstr
2008-05-03 21:04 ` Arnd Bergmann [this message]
2008-05-04 8:20 ` [PATCH 1/2] OF: Fix coding style violation in of_device.c and of_platform.c Michal Simek
2008-05-04 19:42 ` Arnd Bergmann
2008-05-05 6:33 ` Michal Simek
2008-05-04 23:56 ` Stephen Rothwell
2008-05-05 0:06 ` David Miller
2008-05-06 8:57 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805032304.58709.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=monstr@monstr.eu \
--cc=monstr@seznam.cz \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.