All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Timur Tabi <timur@freescale.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: mconf.c and bindtextdomain() -- warnings while cross-compiling on OS X
Date: Sun, 4 May 2008 21:08:00 +0200	[thread overview]
Message-ID: <20080504190800.GA23619@uranus.ravnborg.org> (raw)
In-Reply-To: <481E039A.9090605@freescale.com>

On Sun, May 04, 2008 at 01:42:34PM -0500, Timur Tabi wrote:
> Sam Ravnborg wrote:
> 
> >I have queued up following patch. It is obviously correct and builds 
> >without
> >warnings here. Can you give it a try on your box.
> 
> ...
> 
> >+static inline void const char *gettext(const char *txt) { return txt; }
> 
> Drop the "void" on this line and this patch works.
> 
> While you're at it, you'll also need this change:
> 
> --- a/scripts/kconfig/mconf.c
> +++ b/scripts/kconfig/mconf.c
> @@ -773,7 +773,7 @@ static void conf_string(struct menu *menu)
> 
>         while (1) {
>                 int res;
> -               char *heading;
> +               const char *heading;
> 
> On a side note, git-diff gives me this error in mconf.c:
> 
> @@ -924,4 +924,4 @@ int main(int ac, char **av)
>         }
> 
>         return 0;
> -}
> +}
> \ No newline at end of file
> 
> I've never seen it before so I don't know if this is specific to OS X or 
> maybe it's my editor.

I did your suggested changes and applied the patch.
Will be pushed out in a minute.

	Sam



      reply	other threads:[~2008-05-04 19:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-04  3:58 mconf.c and bindtextdomain() -- warnings while cross-compiling on OS X Timur Tabi
2008-05-04  7:33 ` Sam Ravnborg
2008-05-04 18:42   ` Timur Tabi
2008-05-04 19:08     ` Sam Ravnborg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080504190800.GA23619@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=timur@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.