From: Willy Tarreau <w@1wt.eu>
To: "Lothar Waßmann" <LW@KARO-electronics.de>
Cc: NeilBrown <neilb@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: linux-2.6.25: 'mkdir -p' does not work with rootdir as mount point inside a read only filesystem
Date: Mon, 5 May 2008 09:02:15 +0200 [thread overview]
Message-ID: <20080505070214.GA14635@1wt.eu> (raw)
In-Reply-To: <18462.43245.728465.911831@ipc1.ka-ro>
On Mon, May 05, 2008 at 08:27:57AM +0200, Lothar Waßmann wrote:
> I'm using busybox 1.0 (on an embedded PXA320 system).
OK
> > stat64("/dev/a/b/c", 0xbf9175dc) = -1 ENOENT (No such file or directory)
> > umask(0) = 022
> > open(".", O_RDONLY|O_LARGEFILE|O_DIRECTORY) = 3
> > chdir("/") = 0
> > mkdir("dev", 0755) = -1 EEXIST (File exists)
> > stat64("dev", {st_mode=S_IFDIR|0755, st_size=17080, ...}) = 0
> > chdir("dev") = 0
> > mkdir("a", 0755) = 0
> > chdir("a") = 0
> > mkdir("b", 0755) = 0
> > chdir("b") = 0
> > umask(022) = 0
> > mkdir("c", 0777) = 0
> > fchdir(3) = 0
> > close(3) = 0
> >
> This is what strace shows in my case:
> mkdir("/", 0777) = -1 EEXIST (File exists)
> stat64("/", {st_mode=S_IFDIR|0755, st_size=0, ...}) = 0
> mkdir("/dev/", 0777) = -1 EROFS (Read-only file system)
> umask(022) = 022
> write(2, "mkdir: ", 7mkdir: ) = 7
> write(2, "Cannot create directory `/dev/\'", 31Cannot create directory `/dev/') = 31
> write(2, ": Read-only file system\n", 24: Read-only file system
> ) = 24
> io_submit(0x1, 0x1, 0xfbad2088 <unfinished ... exit status 1>
So you should send this trace to the busybox maintainer. It
obviously exhibits a small but easily fixable bug in the
program ; it should check whether the directory exists in
case of error. It seems it only checks for EEXIST.
What puzzles me is why you have this problem only with a new kernel.
I suspect that previous ones did report EEXIST and now we report
EROFS for an existing directory on an ro fs.
Willy
next prev parent reply other threads:[~2008-05-05 7:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 14:50 linux-2.6.25: 'mkdir -p' does not work with rootdir as mount point inside a read only filesystem Lothar Waßmann
2008-05-02 4:52 ` Andrew Morton
2008-05-02 6:55 ` NeilBrown
2008-05-03 6:32 ` Willy Tarreau
2008-05-05 6:27 ` Lothar Waßmann
2008-05-05 7:02 ` Willy Tarreau [this message]
2008-05-05 7:08 ` Lothar Waßmann
2008-05-05 7:28 ` Willy Tarreau
2008-05-05 7:38 ` Lothar Waßmann
2008-05-05 12:02 ` Al Viro
2008-05-02 11:32 ` Dan Noé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080505070214.GA14635@1wt.eu \
--to=w@1wt.eu \
--cc=LW@KARO-electronics.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.