From mboxrd@z Thu Jan  1 00:00:00 1970
From: Samuel Thibault <samuel.thibault@eu.citrix.com>
Subject: Re: [RFC] PVFB: Add refresh period to XenStore parameters?
Date: Mon, 5 May 2008 10:18:09 +0100
Message-ID: <20080505091808.GC4497@implementation.uk.xensource.com>
References: <20080229120806.GA8268@implementation.uk.xensource.com>
	<873ar7ptvh.fsf@pike.pond.sub.org>
	<20080303191804.GA11699@implementation.uk.xensource.com>
	<873ar68spy.fsf@pike.pond.sub.org>
	<20080304144952.GA9230@implementation.uk.xensource.com>
	<873ar67anv.fsf@pike.pond.sub.org>
	<20080304161220.GA9852@implementation.uk.xensource.com>
	<20080501175536.GV4797@implementation.uk.xensource.com>
	<20080502160638.GG4819@implementation.uk.xensource.com>
	<877ie917ix.fsf@pike.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <877ie917ix.fsf@pike.pond.sub.org>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Markus Armbruster <armbru@redhat.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Markus Armbruster, le Mon 05 May 2008 10:26:14 +0200, a écrit :
> Any particular reason for going through xenstore instead of the event
> rings?

Just because it exists.

> If I read your patch correctly, xenfb_read_frontend_fb_config() sets
> request-update in xenstore depending on xenfb->ds->idle, during
> startup.  The only place that changes it is xenfb_update(), which is
> #ifdef CONFIG_STUBDOM.

Err, no, it is not #ifdef CONFIG_STUBDOM.

> What if ds->idle is true when xenfb_read_frontend_fb_config() runs
> during startup of the ordinary (!CONFIG_STUBDOM) backend?  Can this
> happen?

Yes it can, when running a vnc server for instance.  And when later on a
client connects, on next iteration of xenfb_update() the frontend will
be notified.

> Other than that, the change seems to affect only Mini-OS and
> CONFIG_STUBDOM, which are both outside the area of my expertise (and
> frankly, interest).

Well, that could be used in the linux frontend to disable the timer too.
That may interest e.g. laptop users.

Samuel