All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
	petkovbb@gmail.com, jens.axboe@oracle.com
Subject: Re: [PATCH 2/3] ide: set REQ_NOMERGE request flag in ide_do_drive_cmd()
Date: Mon, 5 May 2008 18:31:11 +0200	[thread overview]
Message-ID: <200805051831.12574.bzolnier@gmail.com> (raw)
In-Reply-To: <20080505204334P.tomof@acm.org>

On Monday 05 May 2008, FUJITA Tomonori wrote:
> On Sat, 3 May 2008 15:14:24 +0200
> Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
> 
> > This is a preparation for converting IDE to use blk_execute_rq().
> > 
> > There should be no functional changes caused by this patch.
> > 
> > Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> > Cc: Borislav Petkov <petkovbb@gmail.com>
> > Cc: Jens Axboe <jens.axboe@oracle.com>
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> > ---
> >  drivers/ide/ide-io.c |    2 ++
> >  1 file changed, 2 insertions(+)
> 
> I think that you can drop this since the block layer doesn't check
> REQ_NOMERGE with the way ide_do_drive_cmd queues requests.

Yeah, I see now that REQ_NOMERGE only matters for fs requests.

Dropped.

      reply	other threads:[~2008-05-05 16:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-03 13:14 [PATCH 2/3] ide: set REQ_NOMERGE request flag in ide_do_drive_cmd() Bartlomiej Zolnierkiewicz
2008-05-05 13:02 ` FUJITA Tomonori
2008-05-05 16:31   ` Bartlomiej Zolnierkiewicz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200805051831.12574.bzolnier@gmail.com \
    --to=bzolnier@gmail.com \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=jens.axboe@oracle.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=petkovbb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.