From: Ingo Molnar <mingo@elte.hu>
To: Adrian Bunk <bunk@kernel.org>
Cc: Christoph Lameter <clameter@sgi.com>,
travis@sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [patch 4/4] x86: e820 unification: Extract common functions
Date: Tue, 6 May 2008 14:32:29 +0200 [thread overview]
Message-ID: <20080506123229.GL32591@elte.hu> (raw)
In-Reply-To: <20080506113500.GB2359@cs181133002.pp.htv.fi>
* Adrian Bunk <bunk@kernel.org> wrote:
> > int
> > -e820_any_mapped(u64 start, u64 end, unsigned type)
> > +e820_any_mapped(unsigned long start,unsigned long end, unsigned type)
> > {
> > int i;
> > for (i = 0; i < e820.nr_map; i++) {
>
> This changes the parameters from 64bit to 32bit which looks fishy.
good catch! This could lead to bugs on 32-bit that has physical RAM
addresses over 4GB.
> Are you sure the solution that would both match and be correct isn't
> to change the 64bit one to u64?
agreed.
Ingo
next prev parent reply other threads:[~2008-05-06 12:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-05 19:02 [patch 0/4] [PATCH] x86: Merge e820_32/64 Christoph Lameter
2008-05-05 19:02 ` [patch 1/4] x86: e820.h unification Christoph Lameter
2008-05-05 19:02 ` [patch 2/4] x86: e820 unification: Extract shared comments Christoph Lameter
2008-05-05 19:02 ` [patch 3/4] x86: e820 unification: Common #ifdef __ASSEMBLY Christoph Lameter
2008-05-05 19:02 ` [patch 4/4] x86: e820 unification: Extract common functions Christoph Lameter
2008-05-06 11:35 ` Adrian Bunk
2008-05-06 12:32 ` Ingo Molnar [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-05-06 19:33 [patch 0/4] [PATCH] x86: Merge e820_32/64 V2 Christoph Lameter
2008-05-06 19:33 ` [patch 4/4] x86: e820 unification: Extract common functions Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080506123229.GL32591@elte.hu \
--to=mingo@elte.hu \
--cc=bunk@kernel.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.