All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Edgar E. Iglesias" <edgar.iglesias@axis.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Fragile MAX_OP_PER_INSTR
Date: Tue, 6 May 2008 14:39:13 +0200	[thread overview]
Message-ID: <20080506123913.GF26816@edgar.se.axis.com> (raw)
In-Reply-To: <480DBB9A.2050905@siemens.com>

On Tue, Apr 22, 2008 at 12:19:06PM +0200, Jan Kiszka wrote:
> Hi,
> 
> we ran into a weird SEGFAULT of QEMU which turned out to be a corruption
> of tcg_ctx due to writing beyond gen_opc_buf. The reason for this was a
> too small MAX_OP_PER_INSTR, given a particular toolchain (here the one
> of SLES 10 for x86-32). So far it runs fine with
> 
> #define MAX_OP_PER_INSTR 64
> 
> Does anyone have an idea how to resolve the related comment in exec-all.h?
> 
> /* XXX: make safe guess about sizes */
> 
> Or should we just increase the safety margin?

Hi Jan,

I'm seeing this too, 64 seems to be enough for CRIS aswell. Unless someone has a better suggestion I think we should increase it.

Best regards
-- 
Edgar E. Iglesias
Axis Communications AB

      reply	other threads:[~2008-05-06 12:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-22 10:19 [Qemu-devel] Fragile MAX_OP_PER_INSTR Jan Kiszka
2008-05-06 12:39 ` Edgar E. Iglesias [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080506123913.GF26816@edgar.se.axis.com \
    --to=edgar.iglesias@axis.com \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.