From: Ingo Molnar <mingo@elte.hu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Hugh Dickins <hugh@veritas.com>,
Jeff Chua <jeff.chua.linux@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Gabriel C <nix.or.die@googlemail.com>,
Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: Linux 2.6.26-rc1 - pgtable_32.c:178 pmd_bad
Date: Tue, 6 May 2008 17:15:29 +0200 [thread overview]
Message-ID: <20080506151529.GA6321@elte.hu> (raw)
In-Reply-To: <alpine.LFD.1.10.0805060807520.32269@woody.linux-foundation.org>
* Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Tue, 6 May 2008, Ingo Molnar wrote:
> >
> > hm, the main objection was about whether to turn PAGE_SIZE from
> > unsigned into signed though - and that we didnt do.
>
> No it wasn't.
>
> The main objection was that you SHOULD NOT USE PAGE_SIZE_MASK AT ALL!
>
> You should have used a pagetable-specific macro, becuse PAGE_MASK is
> simply fundamentally WRONG, and has absolutely nothing to do with the
> PFN bits, whether sign-extended or not!
>
> The fact is, the page frane number bits are *not* ~PAGE_MASK or
> anything like that. They share only the low bits - not the high bits.
yeah, indeed, sorry about that. Will sort this type mixing out today.
Ingo
next prev parent reply other threads:[~2008-05-06 15:15 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-06 1:06 Linux 2.6.26-rc1 - pgtable_32.c:178 pmd_bad Jeff Chua
2008-05-06 12:49 ` Ingo Molnar
2008-05-06 13:56 ` Hugh Dickins
2008-05-06 15:04 ` Ingo Molnar
2008-05-06 15:09 ` Linus Torvalds
2008-05-06 15:15 ` Ingo Molnar [this message]
2008-05-06 16:16 ` Linus Torvalds
2008-05-06 16:30 ` Ingo Molnar
2008-05-06 15:32 ` Jeremy Fitzhardinge
2008-05-06 16:12 ` Hugh Dickins
2008-05-06 18:39 ` Linus Torvalds
2008-05-06 19:43 ` Hugh Dickins
2008-05-06 19:49 ` [PATCH] x86: fix PAE pmd_bad bootup warning Hugh Dickins
2008-05-06 19:49 ` Hugh Dickins
2008-05-06 20:06 ` Linus Torvalds
2008-05-06 20:06 ` Linus Torvalds
2008-05-06 20:30 ` Hugh Dickins
2008-05-06 20:30 ` Hugh Dickins
2008-05-08 16:07 ` Nishanth Aravamudan
2008-05-08 16:07 ` Nishanth Aravamudan
2008-05-06 20:22 ` Hans Rosenfeld
2008-05-06 20:22 ` Hans Rosenfeld
2008-05-06 20:36 ` Hugh Dickins
2008-05-06 20:36 ` Hugh Dickins
2008-05-07 23:39 ` Nishanth Aravamudan
2008-05-07 23:39 ` Nishanth Aravamudan
2008-05-06 20:42 ` Dave Hansen
2008-05-06 20:42 ` Dave Hansen
2008-05-08 14:34 ` Hans Rosenfeld
2008-05-08 14:34 ` Hans Rosenfeld
2008-05-08 14:39 ` Hans Rosenfeld
2008-05-08 14:52 ` Dave Hansen
2008-05-08 14:52 ` Dave Hansen
2008-05-08 15:11 ` Hans Rosenfeld
2008-05-08 15:11 ` Hans Rosenfeld
2008-05-08 15:51 ` Dave Hansen
2008-05-08 15:51 ` Dave Hansen
2008-05-08 16:19 ` Hans Rosenfeld
2008-05-08 16:19 ` Hans Rosenfeld
2008-05-08 16:33 ` Nishanth Aravamudan
2008-05-08 16:33 ` Nishanth Aravamudan
2008-05-08 16:51 ` Hans Rosenfeld
2008-05-08 16:51 ` Hans Rosenfeld
2008-05-08 17:16 ` Nishanth Aravamudan
2008-05-08 17:16 ` Nishanth Aravamudan
2008-05-08 18:42 ` Dave Hansen
2008-05-08 18:42 ` Dave Hansen
2008-05-08 18:58 ` Hugh Dickins
2008-05-08 18:58 ` Hugh Dickins
2008-05-08 19:06 ` Dave Hansen
2008-05-08 19:06 ` Dave Hansen
2008-05-08 18:48 ` Hugh Dickins
2008-05-08 18:48 ` Hugh Dickins
2008-05-08 19:49 ` Matt Mackall
2008-05-08 19:49 ` Matt Mackall
2008-05-08 20:08 ` Dave Hansen
2008-05-08 20:08 ` Dave Hansen
2008-05-08 20:02 ` Hans Rosenfeld
2008-05-08 20:02 ` Hans Rosenfeld
2008-05-08 20:16 ` Dave Hansen
2008-05-08 20:16 ` Dave Hansen
2008-05-08 23:15 ` Dave Hansen
2008-05-08 23:15 ` Dave Hansen
2008-05-14 19:01 ` Matt Mackall
2008-05-14 19:01 ` Matt Mackall
2008-05-09 9:03 ` Paul Mundt
2008-05-09 9:03 ` Paul Mundt
2008-05-08 16:42 ` Dave Hansen
2008-05-08 16:42 ` Dave Hansen
2008-05-08 15:44 ` Nishanth Aravamudan
2008-05-08 15:44 ` Nishanth Aravamudan
2008-05-07 4:40 ` Jeff Chua
2008-05-07 4:40 ` Jeff Chua
2008-05-07 5:30 ` Hugh Dickins
2008-05-07 5:30 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080506151529.GA6321@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=hugh@veritas.com \
--cc=jeff.chua.linux@gmail.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nix.or.die@googlemail.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.