Re: [PATCH 2/3] svcrdma: Remove extra check for XPT_DEAD bit in svc_xprt_enqueue

["J. Bruce Fields" <bfields@fieldses.org>]

On Fri, May 02, 2008 at 11:18:05AM -0500, Tom Tucker wrote:
> Remove a redundant check for the XPT_DEAD bit in the svc_xprt_enqueue
> function. This same bit is checked below while holding the pool lock

Yeah, seems pointless.  I wonder how it got there.

--b.

> and prints a debug message if found to be dead.

> 
> Signed-off-by: Tom Tucker <tom@opengridcomputing.com>
> 
> ---
>  net/sunrpc/svc_xprt.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c
> index 74e52d4..fb8a785 100644
> --- a/net/sunrpc/svc_xprt.c
> +++ b/net/sunrpc/svc_xprt.c
> @@ -296,8 +296,6 @@ void svc_xprt_enqueue(struct svc_xprt *xprt)
>  	if (!(xprt->xpt_flags &
>  	      ((1<<XPT_CONN)|(1<<XPT_DATA)|(1<<XPT_CLOSE)|(1<<XPT_DEFERRED))))
>  		return;
> -	if (test_bit(XPT_DEAD, &xprt->xpt_flags))
> -		return;
>  
>  	cpu = get_cpu();
>  	pool = svc_pool_for_cpu(xprt->xpt_server, cpu);