Re: [PATCH take 2 01/28] VFS: introduce writeback_inodes_sb()

[Andrew Morton <akpm@linux-foundation.org>]

On Tue,  6 May 2008 13:35:32 +0300 Artem Bityutskiy <Artem.Bityutskiy@nokia.com> wrote:

> Let file systems to writeback their pages and inodes when needed. This
> is needed for UBIFS budgeting sub-system because it has to force
> write-back from time to time.
> 
> Note, it cannot be called if one of the dirty pages is locked by
> the caller, otherwise it'll deadlock.
> 
> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
> Signed-off-by: Adrian Hunter <ext-adrian.hunter@nokia.com>
> ---
>  fs/fs-writeback.c         |    8 ++++++++
>  include/linux/writeback.h |    1 +
>  2 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index 0655767..4591270 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -573,6 +573,14 @@ void sync_inodes_sb(struct super_block *sb, int wait)
>  	spin_unlock(&inode_lock);
>  }
>  
> +void writeback_inodes_sb(struct super_block *sb, struct writeback_control *wbc)
> +{
> +	spin_lock(&inode_lock);
> +	sync_sb_inodes(sb, wbc);
> +	spin_unlock(&inode_lock);
> +}
> +EXPORT_SYMBOL_GPL(writeback_inodes_sb);
> +
>  /*
>   * Rather lame livelock avoidance.
>   */
> diff --git a/include/linux/writeback.h b/include/linux/writeback.h
> index b7b3362..0083a0a 100644
> --- a/include/linux/writeback.h
> +++ b/include/linux/writeback.h
> @@ -71,6 +71,7 @@ struct writeback_control {
>  void writeback_inodes(struct writeback_control *wbc);
>  int inode_wait(void *);
>  void sync_inodes_sb(struct super_block *, int wait);
> +void writeback_inodes_sb(struct super_block *sb, struct writeback_control *wbc);
>  void sync_inodes(int wait);
>  

This looks rather similar to
http://userweb.kernel.org/~akpm/mmotm/broken-out/reiser4-sb_sync_inodes.patch

Which is best?