From: Eric Sesterhenn <snakebyte@gmx.de>
To: linux-kernel@vger.kernel.org
Cc: akpm@osdl.org, zippel@linux-m68k.org
Subject: [Patch] hfsplus oops on image without extends
Date: Wed, 7 May 2008 12:42:44 +0200 [thread overview]
Message-ID: <20080507104244.GD2340@alice> (raw)
hi,
the following patch fixes an oops with a corrupted hfs+ image.
see http://bugzilla.kernel.org/show_bug.cgi?id=10548 for details.
Problem is that we call hfs_btree_open() from hfsplus_fill_super() to set
HFSPLUS_SB(sb).[ext_tree|cat_tree]
Both trees are still NULL at this moment. If hfs_btree_open() fails for
any reason it calls iput() on the page, which
gets to hfsplus_releasepage() which tries to access HFSPLUS_SB(sb).*
which is still NULL and oopses while dereferencing it.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6/fs/hfsplus/inode.c.orig 2008-05-07 14:37:31.000000000 +0200
+++ linux-2.6/fs/hfsplus/inode.c 2008-05-07 14:38:05.000000000 +0200
@@ -65,6 +65,8 @@ static int hfsplus_releasepage(struct pa
BUG();
return 0;
}
+ it (!tree)
+ return 0;
if (tree->node_size >= PAGE_CACHE_SIZE) {
nidx = page->index >> (tree->node_size_shift - PAGE_CACHE_SHIFT);
spin_lock(&tree->hash_lock);
next reply other threads:[~2008-05-07 10:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-07 10:42 Eric Sesterhenn [this message]
2008-05-09 13:13 ` [Patch] hfsplus oops on image without extends Andy Whitcroft
2008-05-09 14:26 ` Eric Sesterhenn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080507104244.GD2340@alice \
--to=snakebyte@gmx.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.