From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JtjCT-0002sd-0p for mharc-grub-devel@gnu.org; Wed, 07 May 2008 08:56:49 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JtjCR-0002s9-HW for grub-devel@gnu.org; Wed, 07 May 2008 08:56:47 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JtjCP-0002rJ-Se for grub-devel@gnu.org; Wed, 07 May 2008 08:56:47 -0400 Received: from [199.232.76.173] (port=42728 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JtjCP-0002r7-GQ for grub-devel@gnu.org; Wed, 07 May 2008 08:56:45 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JtjCP-00026J-0U for grub-devel@gnu.org; Wed, 07 May 2008 08:56:45 -0400 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JtjCM-0004v1-7x for grub-devel@gnu.org; Wed, 07 May 2008 14:56:43 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JtjBa-0004Pw-U4 for grub-devel@gnu.org; Wed, 07 May 2008 14:55:54 +0200 Date: Wed, 7 May 2008 14:55:54 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080507125554.GC16492@thorin> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Workaround for the keyboard hang problem in intel mac X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 May 2008 12:56:48 -0000 On Wed, May 07, 2008 at 01:12:08AM +0800, Bean wrote: > Hi, > > This patch fix the keyboard hang problem when using boot camp to load > legacy system. > > diff --git a/kern/i386/pc/startup.S b/kern/i386/pc/startup.S > index 5d4bbcb..455233a 100644 > --- a/kern/i386/pc/startup.S > +++ b/kern/i386/pc/startup.S > @@ -1240,6 +1240,19 @@ FUNCTION(grub_console_getkey) > call prot_to_real > .code16 > > + pushfw > + sti > + > +1: > + movb $1, %ah > + int $0x16 > + jnz 2f > + hlt > + jmp 1b > + > +2: > + popfw > + movb $0, %ah I think it'd be nice to have a comment there explaining why this is done. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)