From: Samuel Thibault <samuel.thibault@eu.citrix.com>
To: xen-devel@lists.xensource.com
Subject: [PATCH] minios: clear the event before calling the handler
Date: Thu, 8 May 2008 11:27:13 +0100 [thread overview]
Message-ID: <20080508102713.GE4365@implementation.uk.xensource.com> (raw)
minios: clear the event before calling the handler
since (especially in the SMP case) the handler may make another domain
send an event again, and that must not be lost.
Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com>
diff -r 4965e711fee8 extras/mini-os/events.c
--- a/extras/mini-os/events.c Wed May 07 15:36:32 2008 +0100
+++ b/extras/mini-os/events.c Thu May 08 11:26:26 2008 +0100
@@ -58,9 +58,12 @@ int do_event(evtchn_port_t port, struct
int do_event(evtchn_port_t port, struct pt_regs *regs)
{
ev_action_t *action;
+
+ clear_evtchn(port);
+
if (port >= NR_EVS) {
printk("Port number too large: %d\n", port);
- goto out;
+ return 1;
}
action = &ev_actions[port];
@@ -68,9 +71,6 @@ int do_event(evtchn_port_t port, struct
/* call the handler */
action->handler(port, regs, action->data);
-
- out:
- clear_evtchn(port);
return 1;
reply other threads:[~2008-05-08 10:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080508102713.GE4365@implementation.uk.xensource.com \
--to=samuel.thibault@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.