All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "Eren Türkay" <turkay.eren@gmail.com>, xen-devel@lists.xensource.com
Subject: Re: QEMU "drive_init()" Disk Format Security Bypass
Date: Thu, 8 May 2008 18:23:04 +0100	[thread overview]
Message-ID: <20080508172304.GB31908@redhat.com> (raw)
In-Reply-To: <18467.13858.203078.97403@mariner.uk.xensource.com>

On Thu, May 08, 2008 at 06:19:30PM +0100, Ian Jackson wrote:
> Daniel P. Berrange writes ("Re: [Xen-devel] QEMU "drive_init()" Disk Format Security Bypass"):
> > Well, tap:XXX: style URLS already encode the format explicitly. So if
> > we made QEMU understand that syntax too, then that gives admins the 
> > option to be secure, while keeping file: fas a legacy (unsecure) mode
> > for compatability. This has the added advantage that it'd be the same
> > syntax used for PV-on-HVM drivers, and avoids nasty guessing based on
> > filename.
> 
> Yes, encoding the format explicit is definitely the way forward.
> 
> The question is what to do for existing deployments.  Would the users
> prefer to have their system break now or to get rooted in a month or
> two ?

Then disable all format guessing with file: for HVM guests and make it
only use RAW format - this matches semantics of file: with PV guests.
And let them use tap:XXX: if they want QCow with HVM

Dan.
-- 
|: Red Hat, Engineering, Boston   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

  reply	other threads:[~2008-05-08 17:23 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-08 15:00 QEMU "drive_init()" Disk Format Security Bypass Eren Türkay
2008-05-08 16:58 ` Ian Jackson
2008-05-08 17:12   ` Eren Türkay
2008-05-08 17:12   ` Daniel P. Berrange
2008-05-08 17:18     ` Keir Fraser
2008-05-08 17:19     ` Ian Jackson
2008-05-08 17:23       ` Daniel P. Berrange [this message]
2008-05-08 17:27         ` Ian Jackson
2008-05-08 17:30           ` Daniel P. Berrange
2008-05-09 15:54             ` [PATCH] " Ian Jackson
2008-05-13 17:16               ` Ian Jackson
2008-05-30  9:00                 ` Markus Armbruster
2008-05-30 13:37                   ` Ian Jackson
2008-06-13 15:13                     ` Ian Jackson
2008-06-16 15:38                       ` Markus Armbruster
2008-06-16 15:45                         ` Ian Jackson
2008-06-16 16:37                           ` Markus Armbruster
2008-06-16 16:55                             ` Ian Jackson
2008-06-17 16:58                               ` Markus Armbruster
2008-06-17 16:59                               ` [PATCH] ioemu: Disable format auto-probing in monitor command change Markus Armbruster
2008-06-18 10:22                                 ` Ian Jackson
2008-06-18 11:36                                   ` Markus Armbruster
2008-06-13 15:17                   ` [PATCH] QEMU "drive_init()" Disk Format Security Bypass Ian Jackson
  -- strict thread matches above, loose matches on Subject: below --
2008-05-08 14:02 Eren Türkay
2008-05-08 14:12 ` Daniel P. Berrange
2008-05-08 14:17   ` Eren Türkay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080508172304.GB31908@redhat.com \
    --to=berrange@redhat.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=turkay.eren@gmail.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.