From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Timur Tabi <timur@freescale.com>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] [ALSA] soc - fsl_ssi.c fix "BUG: scheduling while atomic"
Date: Thu, 8 May 2008 23:41:46 +0400 [thread overview]
Message-ID: <20080508194146.GA5816@polina.dev.rtsoft.ru> (raw)
In-Reply-To: <48235248.70305@freescale.com>
On Thu, May 08, 2008 at 02:19:36PM -0500, Timur Tabi wrote:
> Anton Vorontsov wrote:
>
> > We must not sleep with irqs disabled, so replace msleep with mdelay.
> >
> > Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
>
> Acked-By: Timur Tabi <timur@freescale.com>
>
> Anton, can you try testing the code with the call to mdelay/msleep commented
> out?
Ok, I'll try...
> On my quick test, I didn't need it, so I have a suspicion that it was
> needed only for the old 1.0 silicon.
Are there any drawbacks of mdelay'ing? Since some silicons need this
we'd better leave it then.
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2008-05-08 19:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-08 16:01 [PATCH] [ALSA] soc - fsl_ssi.c fix "BUG: scheduling while atomic" Anton Vorontsov
2008-05-08 19:19 ` Timur Tabi
2008-05-08 19:41 ` Anton Vorontsov [this message]
2008-05-08 19:43 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080508194146.GA5816@polina.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.