From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Sergei Shtylyov <sshtylyov@ru.mvista.com>
Subject: Re: [PATCH 4/6] ide: remove IDE_TFLAG_NO_SELECT_MASK taskfile flag
Date: Thu, 8 May 2008 21:58:03 +0100 [thread overview]
Message-ID: <20080508205802.GA5722@flint.arm.linux.org.uk> (raw)
In-Reply-To: <200805071943.24296.bzolnier@gmail.com>
On Wed, May 07, 2008 at 07:43:24PM +0200, Bartlomiej Zolnierkiewicz wrote:
> Always call SELECT_MASK(..., 0) in ide_tf_load() (needs to be done
> to match ide_set_irq(..., 1)) and then remove IDE_TFLAG_NO_SELECT_MASK
> taskfile flag.
>
> This change should only affect hpt366 and icside host drivers since
> ->maskproc(..., 0) for sgiioc4 is equivalent to ide_set_irq(..., 1).
Provided the two channels on icside are serialised (so IDE doesn't
try to enable IRQs on both channels at the same time) it shouldn't
be a problem.
However, since I don't use this driver anymore (using the PATA version
instead) I don't feel it's right for me to ack this change.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2008-05-08 20:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-07 17:43 [PATCH 4/6] ide: remove IDE_TFLAG_NO_SELECT_MASK taskfile flag Bartlomiej Zolnierkiewicz
2008-05-08 20:58 ` Russell King [this message]
2008-05-08 21:22 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080508205802.GA5722@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.