All of lore.kernel.org
 help / color / mirror / Atom feed
From: Venki Pallipadi <venkatesh.pallipadi@intel.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Venki Pallipadi <venkatesh.pallipadi@intel.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	Suresh B Siddha <suresh.b.siddha@intel.com>,
	arjan@infradead.org, Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH] x86: Remove 6 bank limitation in 64 bit MCE reporting code
Date: Thu, 8 May 2008 15:16:59 -0700	[thread overview]
Message-ID: <20080508221659.GA2759@linux-os.sc.intel.com> (raw)
In-Reply-To: <4823705E.1040401@zytor.com>

On Thu, May 08, 2008 at 02:27:58PM -0700, H. Peter Anvin wrote:
> Venki Pallipadi wrote:
> >Eliminate the 6 bank restriction in 64 bit mce reporting code. This 
> >restriction
> >is artificial (due to static creation of sysfs files) and 32 bit code
> >does not have any such restriction.
> >
> >This change helps in reporting the details of machine checks on a machine 
> >check
> >exception with errors in bank 6 and above on CPUs that support those banks.
> >Without the patch, machine check errors in those banks are not reported.
> >
> >We still have 128 (MCE_EXTENDED_BANK) bank restriction instead of max 256
> >supported in hardware. That is not changed in the patch below as it will 
> >have
> >some user level mcelog utility dependency, with bank 128 being used for
> >thermal reporting currently.
> >
> >The patch below does not create sysfs control (bankNctl) for banks higher
> >than 6 as well. That needs some pre-cleanup in /sysfs mce layout, removal 
> >of
> >per cpu /sysfs entries for bankctl as they are really global system level
> >control today. That change will follow. This basic change is critical to
> >report the detailed errors on banks higher than 6.
> >
> >Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
> 
> Any chance you could add unifying the 32 and 64-bit code to your list, 
> since you're already working on eliminating differences there?
> 

It was tried earlier
http://www.ussg.iu.edu/hypermail/linux/kernel/0505.2/0982.html
but never made it.

Yes. Will add that to the todo list.

Thanks,
Venki

  reply	other threads:[~2008-05-08 22:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-08 21:18 [PATCH] x86: Remove 6 bank limitation in 64 bit MCE reporting code Venki Pallipadi
2008-05-08 21:27 ` H. Peter Anvin
2008-05-08 22:16   ` Venki Pallipadi [this message]
2008-05-09  9:37     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080508221659.GA2759@linux-os.sc.intel.com \
    --to=venkatesh.pallipadi@intel.com \
    --cc=andi@firstfloor.org \
    --cc=arjan@infradead.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.