From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Subject: Re: 2.6.26-rc1 regression: ISA DMA broken (bisected) Date: Fri, 9 May 2008 10:55:11 +0200 Message-ID: <20080509085511.GE2592@elte.hu> References: <4823AAF2.7070102@keyaccess.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx3.mail.elte.hu (mx3.mail.elte.hu [157.181.1.138]) by alsa0.perex.cz (Postfix) with ESMTP id DFECF243B1 for ; Fri, 9 May 2008 10:55:21 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: ALSA devel , Rene Herman , Linux Kernel , Jesse Barnes , Glauber Costa , "H. Peter Anvin" , Thomas Gleixner , Pete Clements List-Id: alsa-devel@alsa-project.org * Takashi Iwai wrote: > Thanks for catching it. Yeah, the patch looks buggy. We had an > implicit assumption that dev = NULL for ISA devices that require 24bit > DMA. > > How about the patch below? It's against the latest Linus git tree. good catch! Queued it up for testing. Jesse, do you concur? Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755474AbYEIIzl (ORCPT ); Fri, 9 May 2008 04:55:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752368AbYEIIza (ORCPT ); Fri, 9 May 2008 04:55:30 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:60195 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752262AbYEIIz3 (ORCPT ); Fri, 9 May 2008 04:55:29 -0400 Date: Fri, 9 May 2008 10:55:11 +0200 From: Ingo Molnar To: Takashi Iwai Cc: Rene Herman , Glauber Costa , Thomas Gleixner , Pete Clements , Linux Kernel , ALSA devel , Jesse Barnes , "H. Peter Anvin" Subject: Re: 2.6.26-rc1 regression: ISA DMA broken (bisected) Message-ID: <20080509085511.GE2592@elte.hu> References: <4823AAF2.7070102@keyaccess.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Takashi Iwai wrote: > Thanks for catching it. Yeah, the patch looks buggy. We had an > implicit assumption that dev = NULL for ISA devices that require 24bit > DMA. > > How about the patch below? It's against the latest Linus git tree. good catch! Queued it up for testing. Jesse, do you concur? Ingo