All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] sensors-detect: Check for 1-register-only
Date: Fri, 09 May 2008 12:14:26 +0000	[thread overview]
Message-ID: <20080509141426.40a5d666@hyperion.delvare> (raw)
In-Reply-To: <20080508224145.41cfa3ef@hyperion.delvare>

Hi Achim,

On Fri, 09 May 2008 13:51:30 +0200, achim wrote:
> I tried the patch here. The 1-register chips got detected.

Great! Thanks for testing :)

> There still seem to be other chips causing the smbus master to stop
> working after the sensors-detect run. I tried to exclude the chips
> I could not i2cdump correct (0x47 (some oncpu device) ,0x6e (pcie) and
> 0x70(sensors chip?) ) and also added 0x52, 0x53 amd 0x57 but still no
> luck. After the sensors-detect i can not i2dump chips till a new cold
> start.

For 0x47 you can apply this patch which is already in SVN:
http://www.lm-sensors.org/changeset/5235

> The detection program hangs for a few (2-3) seconds at the LM75 probing 
> line on chip at 0x4e (cpu's thermal interface).

The LM75 detection is complex because the LM75 has no identification
register so we have to use a costly heuristic to identify it reliably.
So I am not surprised that it takes some time and it appears to hang
for a few seconds.

I don't know what device on the SMBus is causing the problem. Can you
please try excluding _all_ the addresses which i2cdetect shows as used?

Note that i2cdump, by default, uses byte transactions, while some
detections in sensors-detect make use of word transactions. It could be
that one of your chips is happy with byte transactions but chokes on
word transactions and then keeps the bus in a busy state. You could use
the "w" mode of i2cdump to test this theory.

Thanks,
-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2008-05-09 12:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-08 20:41 [lm-sensors] [PATCH] sensors-detect: Check for 1-register-only Jean Delvare
2008-05-09  5:03 ` Hans de Goede
2008-05-09  5:06 ` Hans de Goede
2008-05-09  6:46 ` Hans de Goede
2008-05-09 10:43 ` Jean Delvare
2008-05-09 10:47 ` Hans de Goede
2008-05-09 11:51 ` achim
2008-05-09 12:14 ` Jean Delvare [this message]
2008-05-09 15:29 ` Jean Delvare
2008-05-09 17:05 ` Jean Delvare
2008-05-09 17:31 ` achim
2008-05-09 21:02 ` Jean Delvare
2008-05-09 21:16 ` Ludovic Lebègue
2008-05-10 16:40 ` Jean Delvare
2008-05-11 16:23 ` Jean Delvare
2008-05-12 10:53 ` Achim Gottinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080509141426.40a5d666@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.